rrdelaney / reason-scripts

:beginner: Create a ReasonML and React development environment
MIT License
628 stars 58 forks source link

Display the same warning for every single files #38

Closed pauldijou closed 5 years ago

pauldijou commented 6 years ago

Not sure if I did something wrong, but having one warning on my project (inside ./src/libs/Dict.re file) will actually display it as many time as I have files inside the project minus one, the file actually having the warning. Running yarn start.

Compiled with warnings.

./src/frontend/account/Login.re
Warning number 27
  /Users/pauldijou/Work/projects/adlm/src/libs/Dict.re 13:12-16

  11 │     switch (get(key, dict) |> updater) {
  12 │     | None => dict
  13 │     | Some(value) => dict
  14 │     };
  15 │ };

  unused variable value.

./src/index.re
Warning number 27
  /Users/pauldijou/Work/projects/adlm/src/libs/Dict.re 14:15-17

  12 │     };
  13 │
  14 │ let remove = (key, dict) => {
  15 │     /* if (has(key, dict)) {
  16 │         Js.Dict.unsafeDeleteKey(dict, key);

  unused variable key.

./src/app.re
Warning number 27
  /Users/pauldijou/Work/projects/adlm/src/libs/Dict.re 14:15-17

  12 │     };
  13 │
  14 │ let remove = (key, dict) => {
  15 │     /* if (has(key, dict)) {
  16 │         Js.Dict.unsafeDeleteKey(dict, key);

  unused variable key.

./src/libs/Html.re
Warning number 27
  /Users/pauldijou/Work/projects/adlm/src/libs/Dict.re 14:15-17

  12 │     };
  13 │
  14 │ let remove = (key, dict) => {
  15 │     /* if (has(key, dict)) {
  16 │         Js.Dict.unsafeDeleteKey(dict, key);

  unused variable key.

./src/libs/Events.re
Warning number 27
  /Users/pauldijou/Work/projects/adlm/src/libs/Dict.re 14:15-17

  12 │     };
  13 │
  14 │ let remove = (key, dict) => {
  15 │     /* if (has(key, dict)) {
  16 │         Js.Dict.unsafeDeleteKey(dict, key);

  unused variable key.

Search for the keywords to learn more about each warning.
To ignore, add // eslint-disable-next-line to the line before.
rrdelaney commented 6 years ago

Thanks for this find! We're currently working on a solution that will fix this, and should be out with version 1.0. I'll update this issue when I have a 1.0 alpha you can try