search

rrdelaney / reason-scripts

:beginner: Create a ReasonML and React development environment
MIT License
628 stars 58 forks source link

Enable namespacing in bsconfig #45

Closed liubko closed 6 years ago

liubko commented 6 years ago

Would it make sense to add "namespace": true into the template? https://bucklescript.github.io/docs/en/build-configuration.html#name-namespace

rrdelaney commented 6 years ago

I don't think reason-scripts apps should use namespace, it's mostly just for libraries.

liubko commented 6 years ago

IMHO adding namespace wouldn't hurt any apps, and if someone is using it for a library it will only helps

rrdelaney commented 6 years ago

It's currently really difficult to make a library out of an app created from reason-scripts, so idk how relevant it is. If anything adding that option might be misleading.