search

rrdelaney / reason-scripts

:beginner: Create a ReasonML and React development environment
MIT License
628 stars 58 forks source link

suggestion: add `npm install` in readme "Getting Started" steps #49

Closed canadaduane closed 6 years ago

canadaduane commented 6 years ago

I followed the npm steps in the readme:

$ npm install -g bs-platform
$ npx create-react-app <app-name> --scripts-version reason-scripts
$ cd <app-name>
$ npm start

but I was shown a blank page. It took me a few minutes to realize I need to npm install all of the dependencies (i.e. node_modules) in the project first.

Perhaps the steps should read as follows?

$ npm install -g bs-platform
$ npx create-react-app <app-name> --scripts-version reason-scripts
$ cd <app-name>
$ npm install
$ npm start
rrdelaney commented 6 years ago

I don't think this should be needed on the latest beta, can you try it with reason-scripts@1.0.0-beta1?