rre36 / ShaderpackIssueTracker

https://rre36.com/
Other
5 stars 0 forks source link

Any emissive item held in hand blinds the player, not playable in survival at night #30

Closed hardtopnet closed 2 years ago

hardtopnet commented 3 years ago

Describe the bug Any held emissive block will cause exposure to go bananas and completely blind the player which makes holding lanterns or such for survival exploration impossible. This happens with most Kappa shaders (also happens with Nostalgia to a lesser extent)

To Reproduce Steps to reproduce the behavior: 1- load Kappa v3.0, v3.1, v4.0, v4.1, PT... 2- set time to midnight 3- without anything in hand, look around to check the overall exposure 4- put a sea lantern in hand 5- image

Expected behavior not image

Screenshots

https://user-images.githubusercontent.com/54667527/120324007-681e1280-c2e6-11eb-92d8-0fd5a52e8eae.mp4

Environment (please complete the following information): Optifine Version: OptiFine_1.16.5_HD_U_G8 Minecraft Version: 1.16.5 Shaderpack Version: Kappa since v3.0 Graphics Card and Driver Version: nVidia GeForce RTX3080 Operating System: Windows 10 2004 (19041) CPU: MAD Ryzen 7 3700x Amount of System Memory (total and assigned to Java): 64GB / 3GB to the Java machine

Additional context If the UI and hand is hidden the issue goes away, which might indicate something to do with SSPT/SSGI or bloom

OKTAYMERCAN commented 3 years ago

That's true this exist on kappa 4.0, auto exposure settings killing atmosphere. Can't see anything. We are not camera device, make this like SEUS PTGI.

I leave example SS for this.

2021-06-05_21 06 00

rre36 commented 3 years ago

Handheld emitters are indeed an issue currently, the general luminance range is not, which means that what is referred to in the second message is not an issue but intentional as is. The latter however is a matter of preference and can be adjusted in the settings.

hardtopnet commented 3 years ago

Tbh I feel this is more of a bugfix than an improvement, as it completely breaks survival gameplay. Side note, if you manage to find an acceptable (and easy enough) solution, would you maybe backport it to 3.0/3.1? Those shader versions are different enough so that some people might prefer them (and they don't require latest Optifine changes so they're backward compatible with versions 1.14, 1.12 and possibly below). They also might have slightly better performance so people with lower end specs might prefer them (not sure about this one though).

OKTAYMERCAN commented 3 years ago

Thanks for answer, this auto exposure correct ok, but contrast too much for gameplay. I try/test lots of different exposure, color etc. settings but still same :( can't see anything and can't playable.

2021-06-06_01 36 09

and addionaly if I close volumetric fog under atmosphere tab, image will be foggy here is example

Volumetric fog: on

2021-06-06_01 51 00

Volumetric fog: off

2021-06-06_01 50 38

I hope this problems fix on future updates, again thanks for answer.

rre36 commented 3 years ago

You can raise the minimum ambient light to reduce the darkness relative to the emission, and the non-volumetric fog thing seems to be a bug.

OKTAYMERCAN commented 3 years ago

Thanks for the advice but I say I try lots of different settings. this include rise min ambient light too but still same result.

rre36 commented 2 years ago

Resolved through various auto exposure and lighting changes coming with future updates.