search

rre36 / ShaderpackIssueTracker

https://rre36.com/
Other
5 stars 0 forks source link

Stop small amounts of water to continuously darken things behind them as if they are submerged in water #38

Closed StarDDDude closed 2 years ago

StarDDDude commented 3 years ago

Describe the bug When you have a thin wall of water and look through it, things which are far away will appear to be deep within water

To Reproduce Steps to reproduce the behavior:

  1. Open a World
  2. Build a 1-Block Deep Waterlayer on a glass platform in the sky
  3. Put some opaque blocks under one half of the platform
  4. The Half with no Blocks directly beneath should appear significantly darker

Expected behavior The expected result is for the water to only darken things by the amount of its thickness So when water is set to darken things by 10% per block and you have 10 Block air gap between the water surface and rendered block, it should only darken the outcome by 10% instead of 100%

Screenshots Here are a few examples using all the different shaders Take into consideration that the left half of the surface is fully submerged in water beyond the glass

VanillaPlus (I added some dirt on the right to show the amount I'd expect the lower parts to have changed their color): Expected

UShader: UShder

Simplissimus (even though this one is obvious): Simplissimus

Kappa Kappa

Take note that I have set the water density of the shaders as following: Kappa: Density = 0.4 VanillaPlus: Falloff = 0.3 Simplissimus: Has none UShader: Has none (I think)

Example Build using Kappa with 0.4 Density Example in Build 04

Example Build using Kappa with 1.0 Density Example in Build 10

This does not happen for the standard shader, due to it only changing the lighting when entering the water: (Simplissimus does not do the same from my testing)

StandartTest

StandartBuild

Environment: Optifine Version: 1.17.1 HD U G9 Minecraft Version: 1.17.1 Shaderpack Version: Kappa 4.1 Simplissimus 1.2 UShader 1.1 VanillaPlus 3.0 Graphics Card and Driver Version: Nvidia GeForce GTX 1050 Ti Operating System: Windows CPU: AMD Ryzen 5 3600X Amount of System Memory (total and assigned to Java): total: 16GB java: I have no clue

Extra info: For some reason the auto correct has recognized Kappa as being a word Your shaders have gained the official recognition they deserve :kappa:

I know this should prolly be a feature request, but I realized too late So enjoy the needlessly much info

rre36 commented 3 years ago

This is unfortunately a technical limitation caused by optifine/minecraft itself as there currently isnt a way to get the location of the further water surface, so the best way is to just assume the depth of whatever solid object is behind it as where the water ends.