search

rre36 / ShaderpackIssueTracker

https://rre36.com/
Other
5 stars 0 forks source link

Modded lights compat. #53

Closed ShibeTemple closed 2 years ago

ShibeTemple commented 2 years ago

Hello! I was wondering, for NostalgiaVX if it is possible to add support for modded light sources? All of them seem to have no emissive light.

Reeses-Puffs commented 2 years ago

It would be tedious to add support for every block in every mod so that they're lit correctly. Your best bet is waiting for Focal Engine.

ShibeTemple commented 2 years ago

It would be tedious to add support for every block in every mod so that they're lit correctly. Your best bet is waiting for Focal Engine.

I don't understand this notion. Why can there not be a default value? Other shaders do this successfully. Identify it's a light source, then emit a standard color if not preset.

Reeses-Puffs commented 2 years ago

Other shaders do this successfully because they don't use the advanced lighting system that NostalgiaVX uses. To add support for modded blocks would you literally have to add each block and what type of block it is by hand into whichever program voxelizes the world. Focal Engine isn't going to remedy this completely, but it will make mod compatibility much easier.

ShibeTemple commented 2 years ago

Other shaders do this successfully because they don't use the advanced lighting system that NostalgiaVX uses. To add support for modded blocks would you literally have to add each block and what type of block it is by hand into whichever program voxelizes the world. Focal Engine isn't going to remedy this completely, but it will make mod compatibility much easier.

Does the shader program not pass the light output of a block? There could be a default handler in the voxel-based method.

rre36 commented 2 years ago

The issue is that NostalgiaVX does not use the vanilla lightmap at all in favour of the much higher quality lighting using voxels and path-tracing. This is why manual mapping is necessary atm, since there is no way for it to reliably detect emitters otherwise for now.