rrealmuto / OoT-Randomizer

A randomizer for Ocarina of Time.
Other
9 stars 5 forks source link

Incorrect logics #102

Closed JustAMosquito closed 2 months ago

JustAMosquito commented 5 months ago

Back again with more enemies, boulders and pots logics that may need correction.

  1. Water Temple Before Compass Chest Stingrays 1 to 4 only spawn when the water is at the top level, meaning that you need Iron Boots and Hookshot. You cannot bypass that with Zelda's Lullaby.
  2. Water Temple South Basement Shell Blade and Water Temple Dragon Statue Shell Blade 1 and 2 are missing _IronBoots and Hookshot. I don't think there's another way to defeat them underwater.
  3. Spirit Temple MQ Silver Block Hallway Chest must have the logic to pass the boulder instead of just _hasbombchus. That or relocate this check to the Spirit Temple Shared region and remove _hasbombchus
  4. With Shuffle Empty Pots on (I think that's the setting that's causing this), the pots in DMC can be obtainable as child. But their logic is only _isadult. So maybe either make those pots no more collectable as child, or add the logic if this setting is active (if it's possible)

The next points are some improvements/additions to some checks. Their logics aren't wrong as of now but there can be other ways to get their check.

  1. Ganons Castle MQ Shadow Trial Beamos 1 must be in the Ganons Castle Shadow Trial Moving Platform region and 2 to 4 must be in the Ganons Castle Shadow Trial Second Gap region instead of just the Ganons Castle Shadow Trial region. Their logic should then just be _can_killbeamos
  2. Both Ganons Castle Shadow Trial Bubble and Ganons Castle Shadow Trial Like Like can be killed as child with Slingshot from the entrance. This could also apply to Ganons Castle MQ Shadow Trial Bubble, but since the requirement to access the Shadow Trial region is _isadult, it would mean to change this logic to True and add is_adult to the other checks in Ganons Castle Shadow Trial and the exit to Ganons Castle Shadow Trial Moving Platform logics. Your call for that

I hope everything is clear enough. As always, don't hesitate to ask for clarification or just to correct me.

JustAMosquito commented 5 months ago

Another one I just saw in my current seed :

Spirit Temple MQ Lobby to Adult Spirit Temple needs the boulder logic instead of just _hasbombchus, unless this boulder in particular isn't randomized due to the fact that it has to only be brown to access the shared region.

JustAMosquito commented 5 months ago

Last one I found while finishing my current seed :

Jabu Jabus Belly MQ Main to Jabu Jabus Belly Invisible Enemies Room should have Jabu Jabus Belly Parasitic Tentacle Cleared instead of _(at('Jabu Jabus Belly Depths', has_soul(Jabu_JabuTentacle)). The parasitic tentacle is blocking this entrance. And if the boulders blocking the swicth and the entrance to defeat this tentacle aren't passable as child, there is no way to enter the invisible enemies room.

rrealmuto commented 5 months ago

The boulder on the ceiling in MQ Spirit is forced to stay a brown boulder so the two comments about that aren't a problem. I'll go ahead and fix the others as you've suggested. Thanks for the input as always.

JustAMosquito commented 5 months ago

Sorry for the confusion, but for the Spirit Temple MQ Silver Block Hallway Chest, I wasn't talking about the boulder on the ceiling, but the boulder between the Child Beginning region and the Child Climb region (see the picture below). You need to hit the eye-switch as child for the chest to appear, and for that child has to pass this boulder to reach the hallway. So the logic for this check should have the same boulder logic as the Spirit Temple shared exit from Child Spirit Temple

image

If I'm still wrong, sorry for that, but that's how I understand it.

And thank you for clarifying the logic for the ceiling boulder. That's good to know that it'll always be brown

rrealmuto commented 5 months ago

I gotcha. Just shows how much I know about MQ :)

rrealmuto commented 4 months ago

These should all be fixed now

JustAMosquito commented 4 months ago

Thank you for fixing them. However, I noticed that the JJB MQ issue I posted (https://github.com/rrealmuto/OoT-Randomizer/issues/102#issuecomment-2075313167) wasn't corrected. Is it because I was wrong with my reasoning or is it just an oversight on your part ?

rrealmuto commented 4 months ago

Just missed it

r0bd0g commented 4 months ago

What you spotted in MQ Spirit with the silver block hallway chest applies to main branch. There's a trick to hammer the boulder as adult so that child could pass through without bombchus, that's not currently being made use of for that chest. You did end up fixing that on this branch.