I found more issues with the current logic, most of them being in Shadow Temple (V and MQ) with Dungeon Boss Shortcuts and Shuffle Enemy Souls. It's sometimes difficult to explain clearly, so I hope you can understand.
In MQ, the logic for the enemies listed in the "Shadow Temple Upper Huge Pit" region should have this code added to their _"cankill" logic :
"not shadow_temple_shortcuts or (Small_Key_Shadow_Temple, 6) or ((logic_lens_shadow_mq_platform or can_use(Lens_of_Truth)) and Hover_Boots)"
In the current logic, if we have 5 keys and use them to unlock all doors except the one leading directly to "Shadow Temple Upper Huge Pit" (meaning we go through the Wind Tunnel with Shortcuts ON) , we cannot have access to these enemies without Hover Boots nor the Lens requirement to cross the pit. With this code, it garanties us to have access from both entrances with their requirements and without running out of keys.
Another idea to solve this issue is to create a new region for these enemies, like this :
I couldn't verify this one in my most recent seed, but I think that in Vanilla, you cannot jump the gap (see picture below) to get back to the "Skulltula Hallway" from the Huge Pit (there is no Longshot target and I don't think you can hookshot the guillotines). Meaning that the 4 Skulltulas and the Wallmaster (and maybe even the Bubble) should have this logic added :
not shadow_temple_shortcuts or (Small_Key_Shadow_Temple, 5).
If there exist a way to cross the gap that is in logic, then you can forget about this point.
"Shadow Temple MQ Huge Pit Lower Beamos" should be placed in the "Shadow Temple Falling Spikes" region, to guarantee its access from both sides with enough keys.
This one I could be wrong, but I think the exit "Shadow Temple Wind Tunnel" from "Shadow Temple Invisible Spikes" should be :
"((has_soul(Redead_and_Gibdo) and Hookshot) or Longshot) and (Small_Key_Shadow_Temple, 3)"
I don't think you can hookshot the nearest target to the door without standing on the chest from the redeads (at least I couldn't do it). The only other way I think to do so would be to hover from the back left platform to the door, but I don't know if it is considered as "in logic" or not. This should apply for both V and MQ.
"Shadow Temple MQ Shortcut Skulltula" should be placed in the "Shadow Temple First Beamos" region, since it's near the invisible chest even with Shortcuts OFF,
"Shadow Temple MQ Before Boat Skullwalltula" should have Longshot or Bow to be sure we can kill it if Shortcuts are ON.
I really hope that everything is clear enough for you to understand. I had some trouble to really understand the Shadow logic so don't hesitate to correct me if I'm still wrong or if you need me to clarify my ideas
I found more issues with the current logic, most of them being in Shadow Temple (V and MQ) with Dungeon Boss Shortcuts and Shuffle Enemy Souls. It's sometimes difficult to explain clearly, so I hope you can understand.
In MQ, the logic for the enemies listed in the "Shadow Temple Upper Huge Pit" region should have this code added to their _"cankill" logic :
"not shadow_temple_shortcuts or (Small_Key_Shadow_Temple, 6) or ((logic_lens_shadow_mq_platform or can_use(Lens_of_Truth)) and Hover_Boots)"In the current logic, if we have 5 keys and use them to unlock all doors except the one leading directly to "Shadow Temple Upper Huge Pit" (meaning we go through the Wind Tunnel with Shortcuts ON) , we cannot have access to these enemies without Hover Boots nor the Lens requirement to cross the pit. With this code, it garanties us to have access from both entrances with their requirements and without running out of keys. Another idea to solve this issue is to create a new region for these enemies, like this :I couldn't verify this one in my most recent seed, but I think that in Vanilla, you cannot jump the gap (see picture below) to get back to the "Skulltula Hallway" from the Huge Pit (there is no Longshot target and I don't think you can hookshot the guillotines). Meaning that the 4 Skulltulas and the Wallmaster (and maybe even the Bubble) should have this logic added :
If there exist a way to cross the gap that is in logic, then you can forget about this point.
not shadow_temple_shortcuts or (Small_Key_Shadow_Temple, 5)."Shadow Temple MQ Huge Pit Lower Beamos" should be placed in the "Shadow Temple Falling Spikes" region, to guarantee its access from both sides with enough keys.
This one I could be wrong, but I think the exit "Shadow Temple Wind Tunnel" from "Shadow Temple Invisible Spikes" should be :
"((has_soul(Redead_and_Gibdo) and Hookshot) or Longshot) and (Small_Key_Shadow_Temple, 3)"I don't think you can hookshot the nearest target to the door without standing on the chest from the redeads (at least I couldn't do it). The only other way I think to do so would be to hover from the back left platform to the door, but I don't know if it is considered as "in logic" or not. This should apply for both V and MQ."Shadow Temple MQ Shortcut Skulltula" should be placed in the "Shadow Temple First Beamos" region, since it's near the invisible chest even with Shortcuts OFF,
"Shadow Temple MQ Before Boat Skullwalltula" should have Longshot or Bow to be sure we can kill it if Shortcuts are ON.
I really hope that everything is clear enough for you to understand. I had some trouble to really understand the Shadow logic so don't hesitate to correct me if I'm still wrong or if you need me to clarify my ideas