Arbitrary logic changes

I'm going through and arbitrarily copy-pasting things around. Maybe there will be some actual bug fixes in here too, who knows. I'm opening this early so you can see progress and tell me I'm dumb for making these random arbitrary changes. (Ignore those files changes unrelated to logic. I'll figure out how to get rid of those later.)

"Highlights"

All:

I'm putting the main checks that are always randomized first in every location list. I'll try to keep a consistent order for the various check types going forward. I want people to be able to see the main checks more immediately.
Removed reverse exits going through dungeons which take up space, don't do anything, and could trick somebody making logic for actually doing dungeons in reverse into thinking they're actually usable.
Removed a lot of unnecessary can_use() for age checking, particularly in places where previous requirements have obviously restricted an area to a certain age.
Renamed some regions and checks to match with nearby checks or their MQ counterparts.
Added additional regions to remove some repetition and to put checks more 'in order' as you would encounter them as you traverse areas. I'll call out most instances of this in the individual area comments.
Reorganized the order of regions or checks to be maybe in a more natural order idk.
Slightly reworded some trick tooltips.

Deku:

Separated the lobby and basement regions. This doesn't actually fix any bugs but it might prevent some in the future.
Created region for the room before the boss.

MQ Deku:

Created region just for the room before the compass room.
Created region for the room before the boss.

DC:

[bugfix][applies to main branch] Added back strength for stunning the lobby scrub, after it was mistakenly removed when adding dungeon shortcuts.
I broke the lower right side off into two new regions.
Changed the vines GS to use an at() rather than repeating full logic for region access.
I broke apart the upper areas into two new regions as well.

MQ DC:

The structure of MQ DC is getting really difficult to understand. I decided to introduce some more strict regioning for the torch puzzle room and surrounding area, hopefully to make it more clear how that section of the dungeon is traversed. With that done I felt I could remove the large comments as hopefully unnecessary. This was a huge overhaul and so I would really appreciate people looking it over to make sure everything is correct.
I also added a region just for the Gohma larvae room to avoid some repetition.
[bugfix] The crates at the bottom of the staircase room can be destroyed using bomb flowers, which of course simplifies away the bonking of the crate since you need either Strength or Explosives to get here.
[bugfix] The crates in the after upper Lizalfos hallway can be destroyed with a bombflower also. Getting to that flower might sometimes involve throwing a pot at a crystal switch, but it can be done with no items.
[bugfix][applies to main branch] Collecting the silver rupees in the staircase room requires you to bonk two crates in a row. I had to remove the Fairy option as we don't currently support carrying more than one Fairy at a time.
[bugfixish] I added Boomerang to one of the pots in the torch puzzle room, to get it from below, allowing the playthrough to maybe skip sticks or something, it basically does nothing. I renamed these two pots.
[bugfix] The crates in the bomb bag area can be destroyed with Strength. And good thing too because otherwise the recoil route from the elevator would be chaining Fairies, which is a no-go and would be annoying to deal with. But luckily any route that goes through the elevator requires something that will satisfy bonkcrate/strength.
[bugfix] One of the crates in the bomb bag area is close enough to a bomb flower to also be destroyed with bow or din's (or blue fire but we don't count that). Renamed the offending crate.
Moved the exit for the child route dropping down the Lizalfos room into the lower Lizalfos region to give it the illusion of being less tacked on. Also added an overdue comment explaining that route.
Renamed Armos Army pots 2 and 3 to 1 and 2, since it's not really clear that upper pot is pot 1.
I split the final area into two regions.

Jabu:

Separated after Big Octo into a new region.

MQ Jabu:

[bugfix][applies to main branch] The exit from the beginning to the elevator room was actually exiting to the main room instead. The only reason this didn't blow up is because there was a 'useless' exit back to the elevator room that I just removed. This was bypassing our intended logic to get from elevator room to main, essentially playing as if the adult jump dive trick is always on for MQ Jabu.
I felt the Compass chest logic was worded a bit strangely, so I rewrote it.

BotW:

I felt some structure was needed for this massive blob of checks but I wasn't really sure what was a good way to do it. I'm not fully sold on what I did here so I'm considering just changing it back.

MQ Botw: (No notable changes)

Forest:

Moved the central room pots into the central room region I added in my logic PR.
Renamed those pots to left/right 123 instead of 123456, matching with how they are named in MQ.
Deleted the duplicate Fairy Pot.
I removed the forest temple well region as unnecessary, moving the recovery hearts into the same region as the water switch. If you can use Irons and access to the well then you can always reach that switch. It's a little strange to have the well checks be most of what's in 'high balconies'. I considered writing out fully the structure of the world regarding the well, but moving the well chest into the well region, it would be kind of gross, and it seems super unnecessary at this time.
Added region for the frozen eye switch room. It's these cases where the logic is currently checking for requirements to get to the next room but the next room in the logic files is maybe two rooms later, I'm thinking I prefer these to chain regions together instead.

MQ Forest:

Added a region for just the straightened hall and the BK chest inside.

Fire:

Added region for lower loop. Not really needed but MQ had one so I decided to match that.
Split into regions all the way up the dungeon.
[bugfix][applies to main branch] The route from upper down to the boss door was not checking for hammer to hammer the pillar because you needed hammer anyway to fight Volvagia, which obviously is not necessarily the case anymore with boss room shuffle.
I felt it made more sense to exit from upper into the boss door rather than using at().

MQ Fire:

[bugfix] Added separate region for the near boss room and added an exit into it from the top so that you can potentially skip fire source by falling down from above.
I felt it made more sense to exit from upper into the boss door rather than using at().
Added region for the shortcut to remove a bit of has_explosives repetition.
[bugfix] All the crates in the near boss room need can_bonk_heated_crate b/c it was decided that holding any direction on the joystick after getting revived from a fairy was too difficult. For crates later in the dungeon, you need Hammer to get there already, so I removed the bonk logic.
[bugfix] Reworked the regions involving the upper maze, shoot torch on wall room, block on fire room, and narrow path room, to allow falling down from above to reach narrow path the pots on one fewer key.
Split into some really unnecessary regions at the top of the dungeon.

Water:

[contentious] I added FTR/Tunic check for methods of obtaining the L2 pots that involve going underwater. There are other treks underwater for similar lengths of time that also require the tunic. I know it's dumb for such a short trip. I felt that FTR off is supposed to promise you these tunics in these two dungeons in particular as originally you needed the tunic in logic to even enter these dungeons. Once ER was added it didn't really make sense to, like, immediately require tunic for the unheated/abovewater lobby of the dungeon you just randomly appeared in. So I figured, sure you can take a look around, but once you start having to go underwater or into heated areas, it was important to start keeping that promise again. (There's an exception here, in that in order to leave the dungeon, you do have to briefly go underwater.) To remove this tunic requirement from the logic we would first have to create a new paradigm for when tunics should be required in the Water and Fire temples. More than just these pots would be affected by such a shift.
Added the "Lowered Water Levels" region as seen in MQ.
Added region for South Basement to avoid some repetition.
Removed some unnecessary instances of Raise_Water_Level. (They were added only because everything in old highest water level region was moved to the lobby and given the old logic for accessing that region.)
My previous logic PR replaced a section of confusing logic with Raise_Water_Level. This time I was reading the GS Central Pillar logic and I got confused, so I replaced it with Raise_Water_Level. Does it work? Maybe. (RWL in the past was only used for cases where you didn't actually need to raise the water, just you needed to confirm it could be raised IF it were able to be lowered. This check requires that you actually do raise it, but the check is in a lowered water level region already, and so checking RWL here confirms it definitely can be raised.)
Added region for Central Bow Target, and removed the at() in favour of exiting to it from two places.
Added regions for BK chest room and the river.

MQ Water:

I moved all of those checks that were at(dive, true) into the dive region. I removed checking for Iron Boots since you need those to be in that region anyway. I was torn on whether to change zl+bonk on those crates to zl+blastsmash but decided to do it to avoid rechecking bonk/fairy/nayru's. I doubt that has much performance impact really but I also don't think it has much impact on readability either.
[bugfix][applies to main branch] The Spike in the Compass chest room can be defeated with a Stick jumpslash, so you don't actually need explosives.
Added regions for below central pillar, the storage room, and before upper water switch rooms.
Added regions along the Dark Link area progression.
[bugfix] The Before BK Near Torches crates were not checking can_bonk_crate.
[contentious] The submerged crates in the tunnel in the dragon statue room did not have bombchus variants. I noticed most other crates that could be hit with a straight bombchu shot were in logic with chus, so I added them here. These chus however could be relevant even without bonko b/c it's possible you could be here without Irons. Unfortunately you only get one dive before the rupees disappear. I think there's maybe a discussion to be had about bombchus in this PR in general. I'm not sure why two of the crates in Lizalfos hallway don't allow for chus (you could even get one of them with gold scale). I'm not sure any of these crates should be in logic with chus like this. On the other hand I'm not sure why these crates are in logic with chus but with beehives is a trick. I will say that I'm not convinced the normal ways of bonking these underwater crates, fairy or nayru's, are all that user-friendly either, so maybe these annoying bombchu shots are a relief compared to that. I found actually the freestanding key area submerged crates the hardest to do of all the chu uses that I've mentioned anywhere in this list of changes.
[bugfix] Removed checking for bombchus in logic, allowing repeatable bombchu sources to be used when chus aren't in logic.
[contentious] I removed the need to get over to the scarecrow to bombchu the crates in the 3 torches room. If you stand on the edges of the central platform, all of the crates can be hit with straight shots, though the timing might be a bit more precise this way. Overall still I'd say easier than freestanding key area crates.
[bugfix] Split the basement gated areas in several regions. This also fixes the fact that changes that I made in my last PR to Freestanding Key were not applied to the rest of the checks in that room when that PR was merged here.

Shadow:

Added region for 3 pots rupees to avoid repetition. (Especially if a bombchu trick gets added we'll be glad to have this.)
Split the after boat chasm into regions rather than including the full logic for all paths onto all checks.

MQ Shadow:

Added region for 3 pots rupees.
Added region for across the beyond boat chasm, and reorganized which regions beyond boat checks go in.

Spirit:

Moved child spirit loop into its own region. I moved the exit to child before locked door to the lobby.
Added region just for the pot in the hallway to the Anubis room.

MQ Spirit:

[bugfix] To get to the child Gibdo room pots we need Slingshot and bombchus. Bombchus alone is a bit much for the Slugs, so we need Sticks or KSword or Bombs. The problem arises when we try to hit the switches to get across the gap while the Gibdo is still there, he really gums up the works. I added bombs for the slugs, but then I needed to add something for the Gibdos, who can also be defeated with Din's. I considered also Nayru's b/c they can't grab you while using it, and it worked, but it was clown shoes trying to get anything done. I left this off of the Stalfos fight pots so that would have at least some kind of sword item to fight him. (I decided against adding regions in child spirit because I thought the result might be a little messier than I'd like.)
Cut the regions for the hands to match cutting the hands region in vanilla as well. This separation of these chests from the rest of the temple stems from a time when it they had to not be in Spirit Temple proper so that keys for Spirit wouldn't go in the hand chests.
Added regions the whole way up adult climb.

Ice Cavern:

Added regions for Map Room and behind ice walls.

MQ Ice Cavern: (No notable changes)

GTG:

Got rid of the central maze region? It has True access only from the entrance so it wasn't really doing anything, and this matches MQ which also doesn't have a separate region for the central maze.
Moved the exit to Like Like room into the near scarecrow region since you have to get up there to hit the switch.

MQ GTG:

I decided that hiding the Ice Arrow chest in the maze right region just to skip checking Hammer the extra time as maybe a little rude.

Ganon's:

Added regions for the rooms at the ends of the trials.
[bugfix] End of Water Trial pots now confirm adult.
Added regions to Shadow Trial.
Added region to Light Trial.
Added regions to Spirit Trial.

MQ Ganon's:

Added regions for the rooms at the ends of the trials.
Moved logic for Stalfos onto Forest Trial room access. Technically they don't need to be defeated for the freestanding key, but for now we're logically requiring that.
[bugfix] Child cannot climb the ledge to reach the pots at the end of Forest Trial. Actually he can, but it requires a trick jump, so it can't be in default logic.
[bugfix] The route to the Shadow Trial pots with Hookshot instead of Hover Boots hard-requires Bow to spawn the first chest. It was checking for Bow in the wrong place.
Because there was nothing in Fire Trial proper I just put the full logic for the ending on the trial access. (I considered getting rid of these True access regions in the trials because I felt they were clogging things up a bit, but I think some appreciate having the all trials in their own regions.)
Added regions to Light Trial.
Moved logic for first switch of Spirit Trial onto region access since all checks are behind it. Added regions to Spirit Trial.

Bosses:

[bugfix][applies to main branch] Removed non-existant Fairy Pot from KD Boss Room.
[bugfix] Logic for killing the Stalfos in the tower was somehow removed.
Moved Ganondorf's chamber in from the OW file.
Added region for Ganondorf fight.

OW:

[contentious] Put using bombs on beehives into default logic in cases where the hives are low enough to be reached by throwing them.
[bugfix] You can get the underwater rupee nearest the LW->River exit simply by coming in from that entrance. Of course you need a scale anyway to take that entrance from River, but OW ER doesn't care about that.
[bugfix][applies to main branch] There was a check for "not deadly_bonks" which I think should not work correctly now that the setting has multiple damage options.
Brought in the logic update for Fortress/Hideout from the hideout shuffle PR. It's overkill right now, but I felt it'd be a good idea to get a head start on merging this PR with that one. -- I removed aspects of that PR relating to actually shuffling the hideout regions, including the shuffle hideout setting, the separation of the hideout region from the fortress region, and the 'savewarp' field which is not otherwise implemented. I don't fully know what I'm doing as I make some of these changes, so Fenhl should probably verify that I've merged it correctly. -- [change] This also means a new trick was added to separate the Kitchen trick from the outside jump trick. I pared back the description of the outside jump trick from the fortress PR as the lower precise jump is not relevant without the full shuffle. -- Fixed several logic bugs identified in that PR that still haven't been fixed in it. -- [contentious] After taking another look at the guards in the kitchen, I've decided that hookshot is reasonable for all of it. There are just a lot of ways to avoid them. If you have any particular trek that you'd like an explanation of how to do, let me know. -- A new region was required for the table pots. -- After taking another look at the break room, I decided not to include the crates and pots in this room under any logic trick just because that guard staring at the pots is too janky. Maybe someday I will understand her better. But I did notice that child Link is too short to be seen by the guard as you go for the boxes, and it should be safe to deal with the first guard using a sword or stick. (Not that any of this actually matters without hideout ER.)
[bugfix][contentious] Added region for Wasteland crate. Now requires reverse Wasteland trick to access from Colossus entrance.
I decided to rework the bonk helpers due to tree and underwater crate being duplicates, and then market crates on top being called trees unless you want another helper with the same thing. I switched the lot of them to can_bonk, and renamed the others to "break" since using bombs on a crate isn't exactly bonking.
[bugfix] Pierre Platform access from above with a Fairy was considered fine at one point but somewhere in the bonks it was decided using a Fairy in crater isn't safe on OHKO without a Tunic.
[contentious] ZR rupees now require Iron Boots. I added the first rupee-specific trick for the Jump Dive to obtain them without.
Added region for ZF Hidden Cave.

rrealmuto / OoT-Randomizer

Arbitrary logic changes #46