search

rrevenantt / antlr4rust

ANTLR4 parser generator runtime for Rust programming laguage
Other
398 stars 70 forks source link

Update uuid version definition #55

Open weigangd opened 2 years ago

weigangd commented 2 years ago

Since uuid >= 1.0 exists now it would be nice to make the uuid version a little more versatile. The proposed change fixes uuid version mismatches when using this crate with together with uuid >= 1.0.

rrevenantt commented 1 year ago

Hmm.. i guess i am missing something but iirc if you are also using uuid >= 1.0 cargo should happily build two separate versions of it and since uuid types are not exposed in public api it wouldn't cause any mismatches. Also i don't thinks features you have added are required.

So overall i don't see a reason why it is not just a simple version bump, i.e. uuid = "1.*"

weigangd commented 1 year ago

Yes, you are right. It was a copy and paste mistake - sorry for that. The features are not necessary and a simple version bump is enough. I changed it to uuid = "1.*".