XXX_all returns all TerminalNode regardless of type - Githubissues

rrevenantt / antlr4rust

ANTLR4 parser generator runtime for Rust programming laguage

Other

398 stars 70 forks source link

XXX_all returns all TerminalNode regardless of type #83

Open oovm opened 10 months ago

oovm commented 10 months ago

If there is more than one TerminalNode type in the child node, XXX_all cannot obtain the correct leaf node type, and children_of_type will return all TerminalNode.

For example, the results returned by STRING_TEXT_all here include STRING_START and STRING_END

newca12 commented 10 months ago

Can you check that this is not already fix by https://github.com/rrevenantt/antlr4rust/pull/58 ?

oovm commented 10 months ago

Where can I download pre-built jars? I don't know how to build a specific branch version.

newca12 commented 10 months ago

This PR is not merged yet, you have no other choice than built it yourself. Github now allow to fetch PR locally : https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally