search

rriepe / 1pxdeep

Bootstrap theme featuring powerful color scheme controls and a flat design
http://rriepe.github.io/1pxdeep/
494 stars 40 forks source link

Issue with Modals #11

Open aejes opened 10 years ago

aejes commented 10 years ago

Love the project, great work. The only issue I have is that the CSS seems to be a bit mixed up with modals - even on the main demo page -

http://rriepe.github.io/1pxdeep/

if you try the modal you'll see it doesn't get styled as you'd expect

John

rriepe commented 10 years ago

Thanks, John.

The modal's actually just like that. The sometimes-bold colors and flat look of the theme didn't mesh well with the more traditional transparency/overlay modal. So I just dropped the transparency and had it take over the whole screen.

Once it was there, I decided to just section the modal up into header/content/footer, without the arbitrary box around them (although, it's kinda still there, layout-wise). I think it looks great on mobile but yeah, it's a bit weird/unconventional on desktop. The demo modal example is a bad one, and I think it looks a lot better with fuller content. If you try that and still disagree, it's probably only a few rules away from looking like a more traditional modal.