rrirower / DP2SceneGraphWizard

Direct Publisher to SceneGraph wizard.
MIT License
16 stars 1 forks source link

subtitles/closed captions #104

Closed AndrewRCD closed 5 months ago

AndrewRCD commented 5 months ago

I don't know if it is normal or not, so I am asking. Can we add subtitles in multiple languages for the same video? We can in the feed manager, but for some reason, when you build the SDK, it only shows the last entry. If, for example, I add subs in EN, FR, and ES - on TV, it only shows the last entry, ES, and you don't have the option to select another sub. If I change the order in the feed manager and add FR, ES, and EN, I can only see the EN sub.

With the upcoming update in October, when subs will be ..... well, kind of mandatory, I thought I try to see how it works :)

Thanks

rrirower commented 5 months ago

Can you post your feed file that contains more than one subtitle so that I can test?

AndrewRCD commented 5 months ago

of course, subtest.json

thank you

rrirower commented 5 months ago

Thanks, but, I need the actual url to the feed file.

AndrewRCD commented 5 months ago

Ah, let me put it our somewhere - i just made this for you - i used it on a channel I have submitted since and obviously ii deleted all the extra subs to have it work properly.

rrirower commented 5 months ago

Ok, that will work. Having the url allows me to test while running the code.

AndrewRCD commented 5 months ago

sorry, I should have thought of that ...... https://05.hosting-allsuper.info/tests/subs/subtest.json

thank you

rrirower commented 5 months ago

OK, I've identified the bug and have a fix for it. I'll have it in the next release.

AndrewRCD commented 5 months ago

you are awesome, thanks.

rrirower commented 5 months ago

Resolved in 1.0.0.2.