rrirower / DP2SceneGraphWizard

Direct Publisher to SceneGraph wizard.
MIT License
15 stars 1 forks source link

In app search function does not work with only Movies category but works fine with both Movies and series categories. #92

Closed wajidbux closed 4 months ago

wajidbux commented 4 months ago

Hi Michael I am using v1.0.0.0 beta.3 and I'm encountering a very strange problem. I have in total four channels on Roku, two have only movies and two have both movies and series, the in-app search option works perfectly with the latter but it completely freezes, the debug output is attached below

search screen

search-screen

BrightScript Crash Logs with Stacktraces (1)

the other issue is that after a particular movie or episode has finished being watched it does not automatically get removed from the continue watching row list.

rrirower commented 4 months ago

Can you give me the feed url and the steps to reproduce the problem?

wajidbux commented 4 months ago

feed url for movies and series https://mangatv.dreamhosters.com/roku.json

feed url for only movies https://movielandroku.dreamhosters.com/roku.json

after sideloading the channel the search option does not work the entire screen freezes.

rrirower commented 4 months ago

Can you give me an example of a Search string that produces the error?

wajidbux commented 4 months ago

you can use any movie name that shows up on the grid screen, once u click on search and type any alphabet there is a black screen of death.

rrirower commented 4 months ago

I just ran a quick test. It's not hanging. It appears to be timing out processing the search because you have a large number of content items to process. For example, your first row contains 1,580 items!

I'll have to take a closer look to see what, if anything, can be done.

wajidbux commented 4 months ago

I agree there is a lot of content but there was no problem while the channel was in direct publisher. kindly take a look at the third screenshot as well I've been getting this error in the player task on line 103 for a long time now. this error message shows under analytics in the dashboard under channel health in the roku dashboard. Thanks alot

rrirower commented 4 months ago

I will have a fix for the Search issue soon. As for the player task, do you have the Roku Ad Framework enabled?

wajidbux commented 4 months ago

yes the RAF is enabled. Thank you for looking into the issue.

rrirower commented 4 months ago

This seems to work with Roku's sample ad URL. Can you provide the ad server url you are using? And, are you specifying ad breaks?

wajidbux commented 4 months ago

I'm using VAST3 tags.

https://tag.targeting.unrulymedia.com/rmp/215213/0/vast3?devId=ROKU_ADS_TRACKING_ID&w=ROKU_ADS_DISPLAY_WIDTH&h=ROKU_ADS_DISPLAY_HEIGHT&appbundle=ROKU_ADS_APP_ID&appname=Movieland&appstoreurl=https://channelstore.roku.com/details/2baedbba13b6d7a51e607e66298bd8a8/movieland&cntlen=ROKU_ADS_CONTENT_LENGTH&dnt=ROKU_ADS_LIMIT_TRACKING

rrirower commented 4 months ago

Does the display of the player task message prevent you from submitting your channel? It may be a false positive.

wajidbux commented 4 months ago

No, it does not. I have already published 3 versions but that error does not seem to go away. Nothing shows up on the brightscript debugger, just the dashboard under channel analytics.

Yahoo Mail: Search, organise, conquer

On Wed, 6 Mar 2024 at 23:11, @.***> wrote:

Does the display of the player task message prevent you from submitting your channel? It may be a false positive.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>

rrirower commented 4 months ago

I ran a test with your ad server URL. I stepped through the code and everything looked OK. I would assume what you're seeing is a false positive from Roku. I've seen some recent posts on the forum that mention this type of thing happening elsewhere in their framework.

If you haven't already, please consider adding your experiences using this project to discussion #55

rrirower commented 4 months ago

I may have stumbled on the player task issue. I got the error in debug while testing some code. It would only happen if I started a video and immediately returned to the Details screen. An internal Roku array was not initialized for some reason. My code relies on that array. I should have a fix for this also.

wajidbux commented 4 months ago

Ok. Thanks in advance and I will share my experience.

rrirower commented 4 months ago

Resolved in beta.5 release.