rrirower / DP2SceneGraphWizard

Direct Publisher to SceneGraph wizard.
MIT License
15 stars 1 forks source link

Unhighlighted button text UNDER the background image? #98

Closed jsonnentag closed 3 months ago

jsonnentag commented 4 months ago

I had to just do a minimal information input to see what it is supposed to look like when you are on a screen to play and episode. Apparently now when viewing an episode's info the Play/Continue Playing button is highlighted and you can see an icon and text, but the button next to it has text only and no button icon. The text goes from unhighlighted being white to black when the button is highlighted.

So I can now see why I never say the text in the button when it was highlighted, because I set all fonts to white, BUT I also see no text for the unactive button (which ought to be white and visible, since I have a dark background). But there is just empty space.

So is is all unactive/not highlighted button text being written before (or under) the background image?

I can see it when there is no background image specified. (???)

These are the 3 views when the 3 different buttons are highlighted and I have my dark background image that the white text of inactive buttons ought to be visible on.

Also, is one of the Font entries specifically for these buttons and nothing else?

dev

dev-1

dev

jsonnentag commented 4 months ago

I guess I should also note that I changed all of the fonts to system fonts, except for the only 12K "genericons.regular.otf" and I think that is just used for the round dot between video info/characteristics on that line under the title. (But that font file is small, so I just left it, even though I could go with a simple dash between things and consider it fine. Getting rid of the other fonts got the 1 MB set of files down to about 200 K. I'll save some people some memory space.) :)

So if there is something in those buttons that won't work with system fonts that would be good to know.

jsonnentag commented 4 months ago

Just testing again with the original ZIP from the wizard it has to be the font and something not liking to use the System Fonts rather than what it was from the wizard. Because I can see the white text when not highlighted and black text in the the highlighted button with my selected background image.

Which of the fonts in the list is for those buttons and it is ONLY for those buttons? (???)

I don't know about for anybody else, but for me it would be extremely helpful to have a comment associated with each font setting that says what labeling/text that font name is used for in the channel.

jsonnentag commented 4 months ago

I just remembered something else that came to mind when first viewing the latest arrangement of things. . . .

Is there a reason why the icon for the Play or Play all or anything else isn't visible along with the text description even when the button isn't highlighted? It seems clearer to me to have everything applicable (not Continue if nothing has been played yet, for example) visible initially and then just put a box around the active/selected button. The way it is now the text appears but the icon for the button is only visible when it is highlighted. (???)

I also liked the top to bottom (vertical) listing/display of buttons better than the current horizontal version.

rrirower commented 4 months ago

This issue is caused by the changes you've made. The button font is set in the DetailsScreen.brs file in the function SetButtonFont. The code uses a Roku ButtonGroup object. As such, the rendering of the buttons is handled by that object.

I also liked the top to bottom (vertical) listing/display of buttons better than the current horizontal version.

Keep in mind, I cannot design the code for a specific user's specifications. I'm trying to keep the code as generic as possible so that each user can make any changes that meet their own needs.

jsonnentag commented 4 months ago

Keep in mind, I cannot design the code for a specific user's specifications. I'm trying to keep the code as generic as possible so that each user can make any changes that meet their own needs.

Obviously, at some point somebody decided to change the "generic" - because the current (active on Roku) channel (based on "beta2" has things in vertical arrangement and not the current horizontal one. :))

jsonnentag commented 4 months ago

This issue is caused by the changes you've made. The button font is set in the DetailsScreen.brs file in the function SetButtonFont. The code uses a Roku ButtonGroup object. As such, the rendering of the buttons is handled by that object.

OK, I found the location that lists the font it wants to use for the button. I'm guessing it has to be a font that allows size adjustment and that is why the simple system font doesn't work right.

It appears (based on a search for "pkg:/fonts/" and going through all the files) that those 2 font settings are the only ones that are somewhere OTHER THAN in the "fontsupport.brs" file.

image

I'm fine with the White and Black font colors, but where are those set, since I don't see the colors specified in there.

Oh, you can see I set the font to 24 (after I pasted the "Gotham-Medium.otf" back in the fonts subdirectory) and it is much nicer. I (and presumably everybody else) can see it now and the buttons don't look like an afterthought, kind of hidden. :)

dev

jsonnentag commented 4 months ago

Oh, I was also going to say if you put the button font setting in the file with all the other ones I would suggest calling it "ButtonFont" or something so people can easily adjust just those and not have to worry about changing everything else associated with the font names already in there.

rrirower commented 3 months ago

Font issues resolved in version 1.0.0.1. This update should make it easier to manage screen field fonts, colors, etc.