search

rrivirr / rriv

GNU General Public License v3.0
1 stars 9 forks source link

Timing code fix (millis till ready / "warmed up" in loop vs burst count) #95

Closed kenchong48 closed 2 years ago

kenchong48 commented 2 years ago

Will use Ken's code for timing for now

ZavenArra commented 2 years ago

I don't understand what this issue is about right now, can you describe the problem? We made some hack to get around something here?

kenchong48 commented 2 years ago

I believe this was an issue of when is a sensor ready to take samples, vs when is it warmed up (how often/when do we check when it is warmed up), vs how often does a user want to take samples. Across different sensors we could have wanting to take analog readings very fast, as compared to a sensor that can only give samples every 2 seconds

What I implemented only takes samples when the slowest sensor is ready to take readings, and does not log extra values in between that, I don't think this accounts for if all sensors are analog and can read continuously though.

The code for mixing and matching these speeds is something you said you would think through.

kenchong48 commented 2 years ago

Oh, we actually have a different item to look at the reading cycles delay #88 ... I'm not sure what this is then

ZavenArra commented 2 years ago

Closing this issue as not specific enough.