search

rroemhild / docker-ejabberd

Dockerfile for Ejabberd server
MIT License
268 stars 160 forks source link

18.09 #177

Closed mwlczk closed 5 years ago

mwlczk commented 5 years ago

Upgrade to 18.09 : remove invalid/deprecated options from ejabberd.yml

Annotation: in 18.09 many default settings enable the server to support "Compliance Suite 2018 (XEP-0387)". We should go through the ejabberd.yml and delete unneeded entries.

jacksgt commented 5 years ago
  1. Squash your commits into a single commit. You commited some personal settings (e.g. here https://github.com/rroemhild/docker-ejabberd/pull/177/commits/2d9c0bd5482efa56e778d0a7f334e05bce5f8351). See here how to do that.
  2. Why did you remove the line specifiying the build version checkout in https://github.com/rroemhild/docker-ejabberd/pull/177/commits/36f508df1a71c29613257aa962f432541ec0e460? That is required in order to select the correct version.

Apart from that, looks good to me.

mwlczk commented 5 years ago

@Jacksgt thx for the hints and encouraging. Gonna try to take some time to clean up tomorrow. :relaxed:

mwlczk commented 5 years ago

hmm, somehow git is tricking me.