search

rroemhild / docker-ejabberd

Dockerfile for Ejabberd server
MIT License
268 stars 160 forks source link

fixed missing default value quotes for env.get calls in ejabberd.yml.tpl #191

Closed trampi closed 5 years ago

trampi commented 5 years ago

The lookup calls for the environment variables for EJABBERD_MOD_ADMIN_EXTRA and EJABBERD_MOD_VERSION are missing quotes for the default value. They evaluate to false, while they look like they would evaluate to true, e.g.:

  {% if env.get('EJABBERD_MOD_ADMIN_EXTRA', true) == "true" %}

This PR adds quotes (true => 'true'), so that the result of the if for the missing environment variables is truthy.

If they should stay false by default, I would advise to change the default value from true to false instead to avoid ambiguity.

Oh, and by the way: Thank you for docker-ejabberd!

rroemhild commented 5 years ago

Thanks for your contribution!