search

rroller / dahua

Dahua Camera and Doorbell Home Assistant Integration
MIT License
383 stars 74 forks source link

Fix detecting DHI_NVR as doorbell #242

Closed goblinmaks closed 1 year ago

goblinmaks commented 1 year ago

Fix detection DHI_NVR as doorbell

241

goblinmaks commented 1 year ago

@rroller thanks

tomlut commented 1 year ago

I assume this would also fix https://github.com/rroller/dahua/issues/168 ?

goblinmaks commented 1 year ago

@tomlut yes, it should fix #168 also, but to confirm it could you create screenshot of model name as I have attached to #241. Thanks,

tomlut commented 1 year ago

One of my 6 cameras (all connect to the same NVR):

Screenshot 2022-12-15 at 14-24-19 Settings – Home Assistant

goblinmaks commented 1 year ago

@rroller could you please review this PR.

rroller commented 1 year ago

@rroller could you please review this PR.

Will try to get to this very soon

goblinmaks commented 1 year ago

@rroller any update here ?

rroller commented 1 year ago

Thanks for this! Merging!

rroller commented 1 year ago

Released in 0.9.45 - https://github.com/rroller/dahua/releases/tag/0.9.45