search

rroller / dahua

Dahua Camera and Doorbell Home Assistant Integration
MIT License
382 stars 73 forks source link

Possible fix by differentiating newer model floodlightmode APIs for coaxial API use on floodlights. #315

Closed cchamilt closed 1 month ago

cchamilt commented 9 months ago

It appears that some of the earlier models support Coaxial API, but not the floodlightmode. Since the 26 earlier models appear to use LightingV2 OK, this explicitly associates the Coaxial API calls to the 4x models that have floodlightmode.

gkwok1 commented 6 months ago

Any updates on this to fix floodlight issues with Amcrest ASH26 in v0.9.51?

skooj commented 1 month ago

@rroller Any possible update on getting these changes merged into the main branch?

I am not well-versed in git, but I manually made the changes found in this commit to the init.py and light.py files from the most recent release (0.9.59) and can confirm that my ASH26-W floodlight turns on and off as expected.

Prior to making those changes, I still got the errors that I outlined here.

EDIT: I made a fork that includes my changes here. I'd be willing to open a PR as well if that's easier or better.

rroller commented 1 month ago

done. released in https://github.com/rroller/dahua/releases/tag/0.9.60