rroller / dahua

Dahua Camera and Doorbell Home Assistant Integration
MIT License
369 stars 71 forks source link

dahua.light.DahuaInfraredLight need attention #355

Closed Masterz69 closed 1 month ago

Masterz69 commented 2 months ago

Is your feature request related to a problem? Please describe. After HA Core upgrade to 2024.5.3 following appears in log:

Logger: homeassistant.components.light
Source: components/light/__init__.py:1267
integration: Light (documentation, issues)
First occurred: 11:34:49 (1 occurrences)
Last logged: 11:34:49

None (<class 'custom_components.dahua.light.DahuaInfraredLight'>) does not set supported color modes, this will stop working in Home Assistant Core 2025.3, please create a bug report at https://github.com/rroller/dahua/issues

Logger: homeassistant.components.light
Source: components/light/__init__.py:1320
integration: Light (documentation, issues)
First occurred: 11:34:49 (1 occurrences)
Last logged: 11:34:49

Entity None (<class 'custom_components.dahua.light.DahuaInfraredLight'>) is using deprecated supported features values which will be removed in HA Core 2025.1. Instead it should use <LightEntityFeature: 1> and color modes, please create a bug report at https://github.com/rroller/dahua/issues and reference https://developers.home-assistant.io/blog/2023/12/28/support-feature-magic-numbers-deprecation
contagon commented 1 month ago

I'm also getting this for AmcrestRingLight

None (<class 'custom_components.dahua.light.AmcrestRingLight'>) does not set supported color modes, this will stop working in Home Assistant Core 2025.3, please create a bug report at https://github.com/rroller/dahua/issues

I know updates to this were discussed in #328 and an update was pushed for the camera constants, was anything ever done for lights?

rroller commented 1 month ago

Fixed in https://github.com/rroller/dahua/releases/tag/0.9.56

Please reopen if this is still an issue. Thanks!