search

rroller / dahua

Dahua Camera and Doorbell Home Assistant Integration
MIT License
383 stars 74 forks source link

making the changes from PR 315 to the most recent release (0.9.59) to solve floodlight control #372

Closed skooj closed 1 month ago

skooj commented 1 month ago

At the risk of pestering, I am going to make another PR, as it seems this issue continues to get overlooked and the previous pull request (by another user) was never merged.

I was experiencing the issue that was possibly solved with PR 315 for the ability to control the light on my ASH26-W floodlight. Using that fork I was able to get my floodlight to work. However, it was very much an older version and the doorbell button on my AD410 would not trigger in home assistant.

I simply took the changes made to that pull request, applied them to the main branch 0.9.59, and have been using this fork for roughly a week with no issue.

I do not have any other devices aside from my ASH26-W and my AD410, so I am not positive if these changes will break anything else.

rroller commented 1 month ago

At the risk of pestering

Not at all! Thank you, sorry I've been busy and haven't had a lot of time to look at this. Taking a look now!

rroller commented 1 month ago

Released in https://github.com/rroller/dahua/releases/tag/0.9.60

trailiajohn commented 1 month ago

Thank you, I can finally update from 0.9.49