search

rrousselGit / flutter_hooks

React hooks for Flutter. Hooks are a new kind of object that manages a Widget life-cycles. They are used to increase code sharing between widgets and as a complete replacement for StatefulWidget.
MIT License
3.13k stars 179 forks source link

Implement Hook for SearchController #361

Closed snapsl closed 1 year ago

snapsl commented 1 year ago

Resolves #360

rrousselGit commented 1 year ago

Could you add this hook to the README?

Overall looking good! There are just some minor formatting issues. If you fix those, happy to merge.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (07855ac) 99.86% compared to head (84151d8) 99.87%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #361 +/- ## ======================================= Coverage 99.86% 99.87% ======================================= Files 17 18 +1 Lines 765 775 +10 ======================================= + Hits 764 774 +10 Misses 1 1 ``` | [Impacted Files](https://app.codecov.io/gh/rrousselGit/flutter_hooks/pull/361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Remi+Rousselet) | Coverage Δ | | |---|---|---| | [...kages/flutter\_hooks/lib/src/search\_controller.dart](https://app.codecov.io/gh/rrousselGit/flutter_hooks/pull/361?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Remi+Rousselet#diff-cGFja2FnZXMvZmx1dHRlcl9ob29rcy9saWIvc3JjL3NlYXJjaF9jb250cm9sbGVyLmRhcnQ=) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

rrousselGit commented 1 year ago

LGTM, thanks!