search

rrousselGit / flutter_hooks

React hooks for Flutter. Hooks are a new kind of object that manages a Widget life-cycles. They are used to increase code sharing between widgets and as a complete replacement for StatefulWidget.
MIT License
3.07k stars 175 forks source link

Make useCallback hook's keys optional #369

Closed jezsung closed 12 months ago

jezsung commented 12 months ago

Makes the useCallback hook's keys property optional and default to an empty list.

rrousselGit commented 12 months ago

Thanks! Could you add a test for this too? :pray:

codecov[bot] commented 12 months ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (2a6b45c) 99.87% compared to head (3558a74) 99.87%.

:exclamation: Current head 3558a74 differs from pull request most recent head 258b69e. Consider uploading reports for the commit 258b69e to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #369 +/- ## ======================================= Coverage 99.87% 99.87% ======================================= Files 18 18 Lines 775 775 ======================================= Hits 774 774 Misses 1 1 ``` | [Impacted Files](https://app.codecov.io/gh/rrousselGit/flutter_hooks/pull/369?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Remi+Rousselet) | Coverage Δ | | |---|---|---| | [packages/flutter\_hooks/lib/src/primitives.dart](https://app.codecov.io/gh/rrousselGit/flutter_hooks/pull/369?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Remi+Rousselet#diff-cGFja2FnZXMvZmx1dHRlcl9ob29rcy9saWIvc3JjL3ByaW1pdGl2ZXMuZGFydA==) | `100.00% <ø> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

jezsung commented 12 months ago

@rrousselGit Sure, should I also upgrade the version to 0.18.7?

rrousselGit commented 12 months ago

No, I bump versions myself

rrousselGit commented 12 months ago

LGTM, thanks!