onAttach and onDetach is missing on usePageController

rrousselGit / flutter_hooks

React hooks for Flutter. Hooks are a new kind of object that manages a Widget life-cycles. They are used to increase code sharing between widgets and as a complete replacement for StatefulWidget.

MIT License

3.13k stars 179 forks source link

onAttach and onDetach is missing on usePageController #420

Closed Kinwailo closed 2 months ago

Kinwailo commented 6 months ago

Official constructor: PageController({int initialPage = 0, bool keepPage = true, double viewportFraction = 1.0, ScrollControllerCallback? onAttach, ScrollControllerCallback? onDetach})

Hook usePageController: PageController usePageController( {int initialPage = 0, bool keepPage = true, double viewportFraction = 1.0, List<Object?>? keys} )

Spotchi commented 2 months ago

+1 here

rrousselGit commented 2 months ago

Fancy making a PR?