search

rrousselGit / functional_widget

A code generator to write widgets as function without loosing the benefits of classes.
597 stars 46 forks source link

Updated analyzer version #32

Closed atreeon closed 5 years ago

atreeon commented 5 years ago

Updated analyzer version and functional_widget from 0.5.0 to 0.51 (functional_widget_annotations left at 0.5.0 as it references a pub package still at 0.5.0

codecov-io commented 5 years ago

Codecov Report

Merging #32 into master will increase coverage by 0.02%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #32      +/-   ##
=========================================
+ Coverage   98.68%   98.7%   +0.02%     
=========================================
  Files           3       4       +1     
  Lines         304     309       +5     
=========================================
+ Hits          300     305       +5     
  Misses          4       4
Impacted Files Coverage Δ
functional_widget/lib/src/utils.dart 100% <ø> (ø) :arrow_up:
functional_widget/lib/src/parameters.dart 100% <100%> (ø) :arrow_up:
...unctional_widget/lib/function_to_widget_class.dart 98.12% <100%> (ø) :arrow_up:
functional_widget/lib/findBeginToken.dart 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5a23697...02f250c. Read the comment docs.

rrousselGit commented 5 years ago

We'll want not to decrease the test coverage. Otherwise LGTM. 😄

rrousselGit commented 5 years ago

Thanks 👌

taliptako commented 5 years ago

this is not released in pub https://pub.dartlang.org/packages/functional_widget it still says version 0.5

rrousselGit commented 5 years ago

Indeed sorry.

I need to check that it works with the newly added flutter generate command line first (it should). If that's working I'll release it.