search

rrousselGit / functional_widget

A code generator to write widgets as function without loosing the benefits of classes.
597 stars 46 forks source link

Params with unknown types can have attributes #39

Closed ryanhair closed 5 years ago

ryanhair commented 5 years ago

Currently, unknown types (such as Color) break when attributes are used (such as @required). This change causes the correct token to be used in the case of an unknown type with attributes.

codecov-io commented 5 years ago

Codecov Report

Merging #39 into master will increase coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #39      +/-   ##
==========================================
+ Coverage   99.67%   99.67%   +<.01%     
==========================================
  Files           4        4              
  Lines         305      308       +3     
==========================================
+ Hits          304      307       +3     
  Misses          1        1
Impacted Files Coverage Δ
functional_widget/lib/findBeginToken.dart 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 33ab095...13f1b72. Read the comment docs.

rrousselGit commented 5 years ago

Awesome, thanks!