search

rrousselGit / functional_widget

A code generator to write widgets as function without loosing the benefits of classes.
597 stars 46 forks source link

Upgrating `analyzer` version (and fix bugs caused by upgrading) #61

Closed fzyzcjy closed 4 years ago

fzyzcjy commented 4 years ago

The mobx.dart requires analyzer: '>=0.38.5 <0.40.0', while this package forces to be lower. Thus, the two cannot be installed without conflict. So I update the version. In addition, there is a bug when updating it, so I also fix two little lines.

rrousselGit commented 4 years ago

Thanks!

Do you mind upgrading the version used in the code_gen_tester folder too? Otherwise, the CI will not pass

fzyzcjy commented 4 years ago

Done! Waiting for CI now

fzyzcjy commented 4 years ago

Wait a minute, need more changes...

fzyzcjy commented 4 years ago

The dart_style >=1.2.4 <1.2.5 conflicts. So I change to ^1.2.4, is it OK? (It seems that, by semantic versioning, it should not break anything)

fzyzcjy commented 4 years ago

Hmmmm... This problem existed before...? Since the current master is "failing" not "passing" https://travis-ci.org/rrousselGit/functional_widget/jobs/651796953#L372

rrousselGit commented 4 years ago

Indeed, it seems like newer versions introduced a bunch of extra lints.

I'll close this PR and fix everything myself

fzyzcjy commented 4 years ago

OK