search

rrousselGit / functional_widget

A code generator to write widgets as function without loosing the benefits of classes.
597 stars 46 forks source link

Upgrade to later `analyzer` package, which no longer support `isUndefined` #67

Closed truongsinh closed 4 years ago

truongsinh commented 4 years ago

Close #55 Close #63 Close #64

I added several more unit test, one of which seems to be functionally incorrect, but at least it guards against the crash (due to null element.session)

codecov[bot] commented 4 years ago

Codecov Report

Merging #67 into master will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #67   +/-   ##
=======================================
  Coverage   99.67%   99.67%           
=======================================
  Files           4        3    -1     
  Lines         308      310    +2     
=======================================
+ Hits          307      309    +2     
  Misses          1        1
Impacted Files Coverage Δ
...unctional_widget/lib/function_to_widget_class.dart 99.52% <100.00%> (+<0.01%) :arrow_up:
functional_widget/lib/src/parameters.dart 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 41ae3aa...6e33d1d. Read the comment docs.

truongsinh commented 4 years ago

I really hate rounding and floating point number 😒

truongsinh commented 4 years ago

@rrousselGit done upgrading dependencies, though brace for big changes 😂

rrousselGit commented 4 years ago

Haha thanks again for working on that! You're saving me a lot of trouble :heart:

rrousselGit commented 4 years ago

Looks good to me, thanks again!