search

rrousselGit / functional_widget

A code generator to write widgets as function without loosing the benefits of classes.
596 stars 46 forks source link

Update `source_gen` and `build_runner` #86

Closed tim-smart closed 3 years ago

tim-smart commented 3 years ago

Can remove the git dependency when https://github.com/dart-lang/source_gen publishes their null safety work.

rrousselGit commented 3 years ago

source_gen ^1.0.0 was published. Do you want to finish this PR or should I take over?

tim-smart commented 3 years ago

@rrousselGit I have updated the constraint. Not sure if the CI tests will be happy, so you can take over from here :)

tim-smart commented 3 years ago

Yeah as I thought, the CI environment is having issues with the test package:

functional_widget:
error: Library 'file:///home/runner/.pub-cache/hosted/pub.dartlang.org/test-1.16.8/bin/test.dart' was compiled with sound null safety (in strong mode) and it requires --sound-null-safety option at runtime
jonasN5 commented 3 years ago

Any ETA on this? I have to use a custom fork just because of this dependency...

rrousselGit commented 3 years ago

The blocker is code_builder https://github.com/dart-lang/code_builder/issues/303

fdietze commented 3 years ago

Until this PR is merged, you can already use it like this in your pubspec.yaml:

dependencies:
  functional_widget_annotation:
    git:
      url: git://github.com/tim-smart/functional_widget.git
      ref: "ad7f47788160137fe17c9038ab0298e89b4a6f34" # https://github.com/rrousselGit/functional_widget/pull/86
      path: packages/functional_widget_annotation

dev_dependencies:
  functional_widget:
    git:
      url: git://github.com/tim-smart/functional_widget.git
      ref: "ad7f47788160137fe17c9038ab0298e89b4a6f34" # https://github.com/rrousselGit/functional_widget/pull/86
      path: packages/functional_widget

dependency_overrides:
  functional_widget_annotation:
    git:
      url: git://github.com/tim-smart/functional_widget.git
      ref: "ad7f47788160137fe17c9038ab0298e89b4a6f34" # https://github.com/rrousselGit/functional_widget/pull/86
      path: packages/functional_widget_annotation
rrousselGit commented 3 years ago

Looks like code_builder has been released, so I'll finish this