search

rrousselGit / state_notifier

ValueNotifier, but outside Flutter and with some extra perks
MIT License
311 stars 28 forks source link

…Notifier or …Controller? #39

Closed reedom closed 3 years ago

reedom commented 3 years ago

Describe what scenario you think is uncovered by the existing examples/articles

…Notifier is found in the example code https://github.com/rrousselGit/state_notifier/blob/master/example/lib/my_state_notifier.dart#L19

and …Controller is in the comment. https://github.com/rrousselGit/state_notifier/blame/57e64d0a8dc029ad457217cc0f210944083dc212/packages/flutter_state_notifier/lib/flutter_state_notifier.dart#L121-L123

It'd be nice if they've followed the same convention.

Describe why existing examples/articles do not cover this case

It could be a big help to end arguments upon those in teams. 😅

rrousselGit commented 3 years ago

Both are technically correct

I'd say prefer "notifier" because of the class/package name. But "controller" is absolutely fine too. Notifiers are contollers.