search

rrrene / credo

A static code analysis tool for the Elixir language with a focus on code consistency and teaching.
http://credo-ci.org/
MIT License
4.91k stars 415 forks source link

Fix building with Elixir 1.15 #1075

Closed frerich closed 11 months ago

frerich commented 11 months ago

This upgrades the ssl_verify_fun dependency from 1.1.6 to 1.1.7, fixing builds with Elixir 1.15 which would run into errors like

==> ssl_verify_fun
Compiling 7 files (.erl)
src/ssl_verify_fun_cert_helpers.erl:13:14: can't find include lib "public_key/include/public_key.hrl"
%   13| -include_lib("public_key/include/public_key.hrl").
%     |
...
src/ssl_verify_hostname.erl:76:38: record 'OTPCertificate' undefined
%   76|                              Cert :: #'OTPCertificate'{},
%     |                                      ^

could not compile dependency :ssl_verify_fun, "mix compile" failed. Errors may have been logged above. You can recompile this dependency with "mix deps.compile ssl_verify_fun --force", update it with "mix deps.update ssl_verify_fun" or clean it with "mix deps.clean ssl_verify_fun"

This was triggered by CI builds such as https://github.com/rrrene/credo/actions/runs/6364529751/job/17280859870?pr=1074.

Cf. https://github.com/deadtrickster/ssl_verify_fun.erl/pull/27 for further discussion.

rrrene commented 11 months ago

Fat fingers, sorry :+1:

rrrene commented 11 months ago

@frerich This is now live in Credo 1.7.1: https://hex.pm/packages/credo/1.7.1