Credo warning /test/add_credo_plugin_to_project.exs:121:6

rrrene / credo

A static code analysis tool for the Elixir language with a focus on code consistency and teaching.

http://credo-ci.org/

MIT License

4.94k stars 419 forks source link

Credo warning /test/add_credo_plugin_to_project.exs:121:6 #1105

Closed bradhanks closed 10 months ago

bradhanks commented 10 months ago

Credo has a warning there but it looks like it is intentional. Just wanted to check.

Warnings - please take a look
┃ ┃ [W] ↗ There should be no calls to IO.inspect/1. ┃ test/add_credo_plugin_to_project.exs:121:6 #()

rrrene commented 10 months ago

Yeah, this is intentional.

We historically don't fix all the Credo issues in Credo's code and this is one of those cases where the warning does not bother me, but it "shows the check is working".

Another thing is that there are fixtures in test/ that will always yield issues and then we would different Credo configs inside Credo's codebase next to Credo's default config (which would then ironically not run on Credo).

bradhanks commented 10 months ago

Sounds great. Thanks for the context!