search

rrrene / credo

A static code analysis tool for the Elixir language with a focus on code consistency and teaching.
http://credo-ci.org/
MIT License
4.91k stars 414 forks source link

Predicate function names should not start with 'is', and should end in a question mark flagged for :ets.whereis #1130

Closed simondelacourt closed 3 months ago

simondelacourt commented 3 months ago

After upgrading to Credo 1.7.6 from 1.7.5 I've noticed that the :ets.whereis function is flagged als following;

┃ [R] ↗ Predicate function names should not start with 'is', and should end in a 00:03 ┃ question mark.

The issue, at least in the way I look at it, is that this function comes from OTP, and I don't really assume they'd be open to rename this function so it matches credo. I can ignore it locally of course, but I'd assume I'm not the only one using :ets.whereis

rrrene commented 3 months ago

This sounds strange. Can you provide a complete code sample that triggers this?

simondelacourt commented 3 months ago

This sounds strange. Can you provide a complete code sample that triggers this?

@rrrene to be honest, I've completely misread my own code. My dearest apologies. Thanks for the response and credo itself :)