rrrene / credo

A static code analysis tool for the Elixir language with a focus on code consistency and teaching.

http://credo-ci.org/

MIT License

4.94k stars 419 forks source link

Fix for Elixir 1.17 #1136

Closed peaceful-james closed 5 months ago

peaceful-james commented 6 months ago

Welp I gave it a shot. There are still 2 tests failing.

I do not understand yet what this {:"{", {1, 2, nil}} tuple conveys/represents.

peaceful-james commented 6 months ago

1132 is the related issue

peaceful-james commented 6 months ago

Found it :)

here https://github.com/elixir-lang/elixir/blob/v1.17/lib/elixir/src/elixir_tokenizer.erl

So this is just the column number being incorrect.

peaceful-james commented 6 months ago

I think this will fix it: https://github.com/elixir-lang/elixir/pull/13601

peaceful-james commented 6 months ago

My elixir PR was closed. I don't think it is open for discussion, so I will change the tests to expect the new column number.

rrrene commented 5 months ago

@peaceful-james Thx for this! :v:

rrrene commented 5 months ago

@peaceful-james Please check out the RC to see if there are remaining issues: https://github.com/rrrene/credo/releases/tag/v1.7.7-rc.0 🧡

peaceful-james commented 5 months ago

Looks good to me!