rrrene / credo

A static code analysis tool for the Elixir language with a focus on code consistency and teaching.
http://credo-ci.org/
MIT License
4.94k stars 419 forks source link

credo 1.7.9 warning: using map.field notation #1160

Closed nathany-copia closed 2 weeks ago

nathany-copia commented 2 weeks ago

Precheck

Environment

Erlang/OTP 27 [erts-15.1.2] [source] [64-bit] [smp:10:10] [ds:10:10:10] [async-threads:1] [jit] [dtrace]

Elixir 1.17.3 (compiled with Erlang/OTP 26)

What were you trying to do?

mix credo

Expected outcome

no compiler errors or warnings

Actual outcome

❯ mix credo
Checking 1943 source files (this might take a while) ...
warning: using map.field notation (without parentheses) to invoke function Credo.Check.Design.AliasUsage.category() is deprecated, you must add parentheses instead: remote.function()
  (credo 1.7.9) lib/credo/check/params.ex:74: Credo.Check.Params.category/2
  (credo 1.7.9) lib/credo/check.ex:697: Credo.Check.format_issue/3
  (credo 1.7.9) lib/credo/check/design/alias_usage.ex:268: Credo.Check.Design.AliasUsage.do_find_issues/10
  (elixir 1.17.3) lib/macro.ex:609: Macro.do_traverse/4
  (stdlib 6.1.2) lists.erl:2343: :lists.mapfoldl_1/3
rrrene commented 2 weeks ago

@nathany-copia Yeah, that was not my best work 😞 but thanks to the community, we fixed it quickly 😄

Could you check Credo 1.7.10?

Eiji7 commented 2 weeks ago

Fixed by: #1159

nathany-copia commented 2 weeks ago

No problem at all.

Thanks @Eiji7

1.7.10 is working well