search

rrrene / elixirstatus-web

Community site for Elixir project/blog post/version updates
http://elixirstatus.com
MIT License
281 stars 44 forks source link

Get rid off compile time warnings (also for executing tests) #42

Open PragTob opened 8 years ago

PragTob commented 8 years ago

Right now there are quite a lot, especially when running mix test (here I did mix clean before)

Compiled lib/elixir_status/meta.ex
Compiled lib/elixir_status/plugs/remove_reponse_headers_for_embedded.ex
Compiled lib/elixir_status.ex
Compiled lib/elixir_status/auth.ex
Compiled lib/elixir_status/url.ex
Compiled lib/elixir_status/uid.ex
Compiled test/support/conn_login_helper.ex
Compiled test/support/channel_case.ex
Compiled test/support/conn_case.ex
Compiled test/support/model_case.ex
web/controllers/locale.ex:4: warning: variable opts is unused
Compiled web/controllers/locale.ex
Compiled web/oauth/git_hub_auth.ex
Compiled web/models/avatar.ex
Compiled web/views/impression_view.ex
Compiled web/views/short_link_view.ex
Compiled web/views/error_helpers.ex
Compiled web/web.ex
Compiled lib/elixir_status/repo.ex
Compiled web/gettext.ex
Compiled lib/elixir_status/link_shortener.ex
Compiled web/models/short_link.ex
Compiled web/models/impression.ex
web/posting_typifier.ex:77: warning: variable string is unused
Compiled web/posting_url_finder.ex
Compiled lib/elixir_status/impressionist.ex
Compiled web/models/user.ex
Compiled web/models/posting.ex
Compiled web/views/view_helper.ex
web/posting_typifier.ex:29: warning: variable tail is unused
web/posting_typifier.ex:32: warning: variable sum_all is unused
web/posting_typifier.ex:32: warning: variable tail is unused
web/posting_typifier.ex:35: warning: variable points is unused
web/posting_typifier.ex:35: warning: variable type is unused
Compiled web/posting_typifier.ex
Compiled lib/elixir_status/publisher.ex
web/controllers/admin/impression_controller.ex:38: warning: multiple clauses with default values should define a function head with the defaults, defp get_all/1 has multiple clauses and defines defaults in a clause with a body
Compiled lib/elixir_status/plugs/logged_in.ex
Compiled lib/elixir_status/plugs/admin.ex
Compiled lib/elixir_status/plugs/same_user_or_admin.ex
Compiled web/controllers/admin/user_controller.ex
Compiled web/controllers/feed_controller.ex
web/controllers/admin/impression_controller.ex:15: warning: default arguments in get_all/1 are never used
Compiled web/controllers/impression_controller.ex
Compiled web/controllers/github_auth_controller.ex
web/controllers/admin/impression_controller.ex:38: warning: variable params is unused
Compiled web/controllers/admin/overview_controller.ex
Compiled web/controllers/admin/posting_controller.ex
Compiled web/controllers/admin/impression_controller.ex
Compiled web/controllers/page_controller.ex
Compiled web/controllers/short_link_controller.ex
Compiled web/views/changeset_view.ex
Compiled web/views/admin/overview_view.ex
Compiled web/controllers/user_controller.ex
Compiled web/views/admin/user_view.ex
Compiled web/views/admin/impression_view.ex
Compiled web/views/error_view.ex
Compiled web/views/admin/posting_view.ex
Compiled web/views/feed_view.ex
Compiled web/views/page_view.ex
Compiled web/views/layout_view.ex
Compiled web/views/shared_view.ex
Compiled web/views/user_view.ex
Compiled web/router.ex
Compiled web/controllers/posting_controller.ex
Compiled lib/elixir_status/endpoint.ex
Compiled web/views/posting_view.ex
Generated elixir_status app
test/controllers/page_controller_test.exs:12: warning: you are piping into a function call without parentheses, which may be ambiguous. Please wrap the function you are piping into in parentheses. For example:

    foo 1 |> bar 2 |> baz 3

Should be written as:

    foo(1) |> bar(2) |> baz(3)

test/controllers/page_controller_test.exs:19: warning: you are piping into a function call without parentheses, which may be ambiguous. Please wrap the function you are piping into in parentheses. For example:

    foo 1 |> bar 2 |> baz 3

Should be written as:

    foo(1) |> bar(2) |> baz(3)

test/controllers/posting_controller_test.exs:32: warning: you are piping into a function call without parentheses, which may be ambiguous. Please wrap the function you are piping into in parentheses. For example:

    foo 1 |> bar 2 |> baz 3

Should be written as:

    foo(1) |> bar(2) |> baz(3)

test/controllers/posting_controller_test.exs:41: warning: you are piping into a function call without parentheses, which may be ambiguous. Please wrap the function you are piping into in parentheses. For example:

    foo 1 |> bar 2 |> baz 3

Should be written as:

    foo(1) |> bar(2) |> baz(3)

test/controllers/posting_controller_test.exs:50: warning: you are piping into a function call without parentheses, which may be ambiguous. Please wrap the function you are piping into in parentheses. For example:

    foo 1 |> bar 2 |> baz 3

Should be written as:

    foo(1) |> bar(2) |> baz(3)

test/controllers/posting_controller_test.exs:59: warning: you are piping into a function call without parentheses, which may be ambiguous. Please wrap the function you are piping into in parentheses. For example:

    foo 1 |> bar 2 |> baz 3

Should be written as:

    foo(1) |> bar(2) |> baz(3)

test/controllers/posting_controller_test.exs:73: warning: you are piping into a function call without parentheses, which may be ambiguous. Please wrap the function you are piping into in parentheses. For example:

    foo 1 |> bar 2 |> baz 3

Should be written as:

    foo(1) |> bar(2) |> baz(3)

test/controllers/posting_controller_test.exs:82: warning: you are piping into a function call without parentheses, which may be ambiguous. Please wrap the function you are piping into in parentheses. For example:

    foo 1 |> bar 2 |> baz 3

Should be written as:

    foo(1) |> bar(2) |> baz(3)

test/controllers/posting_controller_test.exs:123: warning: you are piping into a function call without parentheses, which may be ambiguous. Please wrap the function you are piping into in parentheses. For example:

    foo 1 |> bar 2 |> baz 3

Should be written as:

    foo(1) |> bar(2) |> baz(3)

test/controllers/posting_controller_test.exs:132: warning: you are piping into a function call without parentheses, which may be ambiguous. Please wrap the function you are piping into in parentheses. For example:

    foo 1 |> bar 2 |> baz 3

Should be written as:

    foo(1) |> bar(2) |> baz(3)

test/controllers/posting_controller_test.exs:144: warning: you are piping into a function call without parentheses, which may be ambiguous. Please wrap the function you are piping into in parentheses. For example:

    foo 1 |> bar 2 |> baz 3

Should be written as:

    foo(1) |> bar(2) |> baz(3)

test/controllers/posting_controller_test.exs:157: warning: you are piping into a function call without parentheses, which may be ambiguous. Please wrap the function you are piping into in parentheses. For example:

    foo 1 |> bar 2 |> baz 3

Should be written as:

    foo(1) |> bar(2) |> baz(3)

test/controllers/posting_controller_test.exs:170: warning: you are piping into a function call without parentheses, which may be ambiguous. Please wrap the function you are piping into in parentheses. For example:

    foo 1 |> bar 2 |> baz 3

Should be written as:

    foo(1) |> bar(2) |> baz(3)

test/controllers/posting_controller_test.exs:181: warning: you are piping into a function call without parentheses, which may be ambiguous. Please wrap the function you are piping into in parentheses. For example:

    foo 1 |> bar 2 |> baz 3

Should be written as:

    foo(1) |> bar(2) |> baz(3)

test/controllers/posting_controller_test.exs:193: warning: you are piping into a function call without parentheses, which may be ambiguous. Please wrap the function you are piping into in parentheses. For example:

    foo 1 |> bar 2 |> baz 3

Should be written as:

    foo(1) |> bar(2) |> baz(3)

test/controllers/posting_controller_test.exs:205: warning: you are piping into a function call without parentheses, which may be ambiguous. Please wrap the function you are piping into in parentheses. For example:

    foo 1 |> bar 2 |> baz 3

Should be written as:

    foo(1) |> bar(2) |> baz(3)

test/controllers/posting_controller_test.exs:219: warning: you are piping into a function call without parentheses, which may be ambiguous. Please wrap the function you are piping into in parentheses. For example:

    foo 1 |> bar 2 |> baz 3

Should be written as:

    foo(1) |> bar(2) |> baz(3)

test/controllers/posting_controller_test.exs:257: warning: you are piping into a function call without parentheses, which may be ambiguous. Please wrap the function you are piping into in parentheses. For example:

    foo 1 |> bar 2 |> baz 3

Should be written as:

    foo(1) |> bar(2) |> baz(3)

test/controllers/posting_controller_test.exs:264: warning: you are piping into a function call without parentheses, which may be ambiguous. Please wrap the function you are piping into in parentheses. For example:

    foo 1 |> bar 2 |> baz 3

Should be written as:

    foo(1) |> bar(2) |> baz(3)

test/controllers/posting_controller_test.exs:304: warning: you are piping into a function call without parentheses, which may be ambiguous. Please wrap the function you are piping into in parentheses. For example:

    foo 1 |> bar 2 |> baz 3

Should be written as:

    foo(1) |> bar(2) |> baz(3)

test/controllers/posting_controller_test.exs:313: warning: you are piping into a function call without parentheses, which may be ambiguous. Please wrap the function you are piping into in parentheses. For example:

    foo 1 |> bar 2 |> baz 3

Should be written as:

    foo(1) |> bar(2) |> baz(3)

test/controllers/posting_controller_test.exs:323: warning: you are piping into a function call without parentheses, which may be ambiguous. Please wrap the function you are piping into in parentheses. For example:

    foo 1 |> bar 2 |> baz 3

Should be written as:

    foo(1) |> bar(2) |> baz(3)

test/elixir_status/publisher_test.exs:59: warning: this clause cannot match because a previous clause at line 51 always matches
........................
rrrene commented 8 years ago

Yepp :D See answer in #37 - it's next on the list!