search

rrrlw / TDAstats

R pipeline for computing persistent homology in topological data analysis. See https://doi.org/10.21105/joss.00860 for more details.
https://rrrlw.github.io/TDAstats
GNU General Public License v3.0
37 stars 8 forks source link

Support for other field coefficients #14

Closed peekxc closed 3 years ago

peekxc commented 4 years ago

This is more of a question.

Is it in the scope of this package to re-adjust the ripser source code to support other coefficients in a prime field?

As you know, this should simply involve replacing areas like e.g. here with the code compiled when the USE_COEFFICIENTS preprocessor variable is enabled in the ripser package.

I imagine usage like

TDAstats::calculate_homology(unif2d, dim=1, p=11)

or something

rrrlw commented 4 years ago

Yes, particularly given that it's a Ripser feature, this would definitely be within the scope of the package. Unfortunately, I won't be able to get to adding it for a while - is this something you would be willing to add to TDAstats?

peekxc commented 4 years ago

Seeing how I'll need it soon, yes I'll fork and PR soon-ish

rrrlw commented 4 years ago

Sounds good, thank you!

peekxc commented 4 years ago

See PR #15 for code changes

rrrlw commented 4 years ago

Sorry I have been slow to respond, it looks like PR #15 has been closed for further editing. Let me know when it's ready or if there's anything with which I can help!

rrrlw commented 3 years ago

solved by #19, thank you @peekxc

code from #19 ported to rrrlw/ripserr (will add this as a TDAstats dependency after CRAN acceptance)