search

rrrlw / TDAstats

R pipeline for computing persistent homology in topological data analysis. See https://doi.org/10.21105/joss.00860 for more details.
https://rrrlw.github.io/TDAstats
GNU General Public License v3.0
37 stars 8 forks source link

fixed coordinates for persistence plot? #2

Closed corybrunson closed 5 years ago

corybrunson commented 5 years ago

Since persistence plots implicitly rely on a 1:1 aspect ratio for visual interpretability, would it be appropriate to include + ggplot2::coord_fixed(ratio = 1) to the 'ggplot' object returned by plot_persist()? (Certainly lower- and higher-persistence features are discriminable regardless of the aspect ratio, but for professional publications this has, to my knowledge, been the rule. And, like the other plot specs, this could be overridden by the user.)

Part of this JOSS review.

rrrlw commented 5 years ago

Yes, you are correct, thank you for the suggestion! The fixed coordinate ratio has been added in commit 1543117.