search

rrrlw / TDAstats

R pipeline for computing persistent homology in topological data analysis. See https://doi.org/10.21105/joss.00860 for more details.
https://rrrlw.github.io/TDAstats
GNU General Public License v3.0
37 stars 8 forks source link

diagonal missing from modified persistence plot #3

Closed corybrunson closed 5 years ago

corybrunson commented 5 years ago

The following code chunk doesn't produce an error, but fails (for me) to produce the diagonal line in the persistence plot (i had trouble using reprex::reprex()):

library(TDAstats)
data(circle2d)
circ.phom <- calculate_homology(circle2d, dim = 1)
plot_persist(circ.phom) + ggplot2::xlim(c(0, .25))

Is the problem on my end? It prevents me from fully performing the visual comparison suggested in the "inference" vignette. I will try to reproduce it on a different machine tomorrow.

Part of this JOSS review.

rrrlw commented 5 years ago

Thank you for pointing this out, this was not a problem on your end. Choosing smaller values for xlim caused an issue with the value that was used to define the diagonal (which, consequently caused the diagonal to not show up). The issue has been fixed in commit fc3da1f (diagonal now defined by slope and intercept).