search

rrrlw / TDAstats

R pipeline for computing persistent homology in topological data analysis. See https://doi.org/10.21105/joss.00860 for more details.
https://rrrlw.github.io/TDAstats
GNU General Public License v3.0
37 stars 8 forks source link

depend on R v3.3 instead of v3.4? #6

Closed corybrunson closed 5 years ago

corybrunson commented 5 years ago

Since i use Mac OS X 10.9 on my laptop, i only have R version 3.3.2. As an experiment, i cloned this repo, changed the dependency to R (>= 3.3), and installed using devtools::install(). It worked fine, and i was able to work through all of the examples. Are there specific reasons for requiring version 3.4?

rrrlw commented 5 years ago

For package versions in DESCRIPTION Imports, I always use the package version I'm using as the oldest acceptable version, but you are right - updating R (when possible) is far more tedious than updating a package.

Followed your recommendation and updated minimum required version of R to 3.3 (commit de79420); thank you for the suggestion!