search

rrsg2020 / analysis

4 stars 0 forks source link

Temp correction #17

Closed jvelazquez-reyes closed 3 years ago

jvelazquez-reyes commented 3 years ago

I'm copying what I wrote in the original issue.

I was testing a cubic and a cubic-spline interpolation from the library Scipy. However I cannot see a significant difference between these interpolations.

When the funtion is called, I passed an array of temperatures. I did this to compare interpolations of the T1 values in a range of temperature. Otherwise, we would be comparing the interpolations at one datapoint (one T1 value at one temperature), although maybe that's what you want.

All this made me wonder how would the user introudce the temperature, as an array or as a single temperature value? During the development stage, I think passing an array is the best way to compare different interpolations

EDIT: I took the liberty of preparing a Jupyter Notebook of the interpolations so that you can interact with two different interpolations and the 14 spheres. Excuse me the messy code, I'll also rename some of the variables, but I would like you to check the interactive plot and see if that's something you were thinking about.

jvelazquez-reyes commented 3 years ago

@mathieuboudreau this is only a reminder in case you missed the previous message.

mathieuboudreau commented 3 years ago

@mathieuboudreau this is only a reminder in case you missed the previous message.

Ahhh thank you! Looking at it now.

mathieuboudreau commented 3 years ago

In the notebook figure, are both the cubic and cubic spline supposed to be overlapping exactly like that?

Capture d’écran 2020-12-17 à 22 35 04
jvelazquez-reyes commented 3 years ago

@mathieuboudreau thank you very much for reviewing the work. I will take a look at each of your comments.

Have you have done unit tests before @jvelazquez-reyes ?

No I haven't but I will try and see if I can implement those tests. Thanks!

jvelazquez-reyes commented 3 years ago

@mathieuboudreau I think I have the unit tests for the temperature_correction tool. I designed the tests in such a way that the preset temperature value is obtained from a dictionary structured as phantom_v2.