search

rrthomas / hpmor

PDF, ePUB and Mobi versions of “Harry Potter and the Methods of Rationality”, from LaTeX source
http://hpmor.com/
295 stars 55 forks source link

Author's note footmarks visible but author's notes invisible #144

Closed twilight-flower closed 1 year ago

twilight-flower commented 1 year ago

In Chapter 001 and Chapter 004, the \authorsnotefootnotemark and \authorsnotetext commands are used. However, currently, the latter is set not to display, with what I assume to have once been its definition commented out, in hp-markup.tex, and replaced with an empty one. As a result, the first chapter's first paragraph and the fourth chapter's title each have these little superscript 1s stuck in them which convey no information at all to readers.

This seems suboptimal relative both to the possibility where they're removed entirely and to the possibility where the text is displayed in a footnote as I gather was once the intent. I don't know which of those options you'd prefer to move towards, but I do suggest moving towards either one or the other, rather than continuing with the unhappy medium currently being held to.

entorb commented 1 year ago

at @rrthomas: could you please check this issue?

rrthomas commented 1 year ago

Thanks both, I've made \authorsfootnotemark print nothing by default.

entorb commented 1 year ago

started the release workflow for 1.2.4