search

rrthomas / hpmor

PDF, ePUB and Mobi versions of “Harry Potter and the Methods of Rationality”, from LaTeX source
http://hpmor.com/
310 stars 57 forks source link

Fix newspaper header issues #169

Closed entorb closed 5 months ago

entorb commented 5 months ago

fixes #168

at @rrthomas : added slight adjustments to the LaTeX code to make .tex -> .html conversion more robust, please check (output should be uploaded here in approx 20 min)

entorb commented 5 months ago

build of branch fails, I assume it is a bug in the pipeline. locally it works:

PDF: image HTML/epub: image

rrthomas commented 5 months ago

build of branch fails, I assume it is a bug in the pipeline. locally it works:

I don't understand where the failure is! In the PR conversation it says "All checks have passed". On the checks page, the balance of red/green implies that 50% of the checks failed. But only one check is shown, and it passed. Further, in the global Actions page, the pipeline run for this PR is shown as green.

Anyway, thanks for fixing this, and the LaTeX changes look fine to me.

rrthomas commented 5 months ago

Ah, also the checks page reached directly from the global actions page shows green and is just one check. It's only the PR's checks page that shows red, and it doesn't show any failed check. Odd.

entorb commented 5 months ago

I manually triggered the build action, that one failed. Will now merge and hope that on main branch it works as expected (and locally)