search

rrthomas / hpmor

PDF, ePUB and Mobi versions of “Harry Potter and the Methods of Rationality”, from LaTeX source
http://hpmor.com/
296 stars 56 forks source link

chapter 109, missing character - #48

Closed yeKcim closed 2 years ago

yeKcim commented 2 years ago

Parseltongue font doesn’t have "-" character. That's a problem in chapter 109: "an intent—who knowss?"

I’ve just add it in my fork (https://github.com/yeKcim/hpmor/commit/95c41b3639772b2d5813fdb6431811252ac671ed).

Is there a way to git pull this commit in your repository easiest than: git checkout my english branch, git add, git commit, git push, pull request?

rrthomas commented 2 years ago

Good catch! Check out your English branch, then use git cherry-pick. Then make a pull request.

rrthomas commented 2 years ago

Did you mean to make a PR for this?

yeKcim commented 2 years ago

yes in few days/weeks, a lot of work actually.

I’ve done a lot of changes on my french branch, I’ll have to talk about it with you (what you need or not, all in one PR or multiple ones…). On my branch: I changed some fonts, I’ve modified epub script converter to use pandoc (simpliest script and font embedded),…

f974f4ff9e80662b

508cdd4a1ce1d0d2

canvas

canvasb

rrthomas commented 2 years ago

I like the look! Also, I see the problem with Parsel that you have to not double silent "s" in French.

entorb commented 2 years ago

Wow, nice fonts, I really like them! Also your title page image looks great. I vote for adopting those.

Interesting that you found a way to use pandoc to generate a proper ebook. I gave up after having quite some issues in trying to make it load my custom css. So I decided to manually convert the tex to simple html...

yeKcim commented 2 years ago

Here is my commit for parseltongue fix only. The other fonts… do you want them?

rrthomas commented 2 years ago

I agree with @entorb, I like them; yes, please!