search

rrthomas / hpmor

PDF, ePUB and Mobi versions of “Harry Potter and the Methods of Rationality”, from LaTeX source
http://hpmor.com/
296 stars 55 forks source link

Alignment with French version by yeKcim #62

Open entorb opened 2 years ago

entorb commented 2 years ago

In https://github.com/yeKcim/hpmor the titlepage, fonts and probably quite some "under the hood" functions have been tuned. I suggest to adept these improvements.

I am currently considering implementing a German LaTeX version, hence it would be nice to have the "old" EN master and the "new and fancy" FR version aligned, so I won't need to cherry pick ;-)

@yeKcim: Could you please enable the GitHub issues feature in your Repo or provide another way of contacting you?

entorb commented 2 years ago

I gave the "french" layout a try and like it very much, see EN PDF in FR layout here: https://github.com/entorb/hpmor-de/releases/download/en-test-fr-layout/hpmor.pdf

Code is in this branch: https://github.com/entorb/hpmor-de/tree/en-layout-from-fr

yeKcim commented 2 years ago

I thought issues were open by default, it should be right now. I REALLY REALLY want to push my modifications in EN repo (as @rjl20 can attest) but my git skills are limited and It is really difficult for me to propose clean patches. I'm glad to read that my changes seem relevant and pleasant to you

entorb commented 2 years ago

I just today figured out how to easily create PRs for the parent/forked EN repo

  1. In my DE repo, I used the "GitHub Desktop" tool to create a branch "hpmor-en" that is based on the last commit before I forked (and modified the repo). So that branch is an outdated but unmodified version of the parent image

  2. In GitHub Web I switch to that branch and "fetch upstream" to sync it with the EN parent image

  3. For each PR, I now plan to create a new feature branch, based on my (up to date) "hpmor-en" branch. For example "en-test-fr-layout"

  4. once this PR-branch is created, I can easily copy files or cherry pick commits from another branch.

  5. finally create a PR using the Web on my repo and my PR-branch

Hope that helps.

entorb commented 2 years ago

addon: I just learned how to easily create branches and PRs for multible forked repos: