search

rrthomas / hpmor

PDF, ePUB and Mobi versions of “Harry Potter and the Methods of Rationality”, from LaTeX source
http://hpmor.com/
305 stars 57 forks source link

Small fixes latex #83

Closed entorb closed 2 years ago

rrthomas commented 2 years ago

Review complete, with comments. I shall try to remember to actually use the review function in future!

rrthomas commented 2 years ago

Great, please could you squash this into a shorter series of commits as neatly as you can, with a full description of what each commit does? Then it will be ready to merge, I think.

entorb commented 2 years ago

Alternatively you could select the squash option on the merge button, if a single commit would be fine for you. If instead you prefer multiple commits I can do the squashing.

entorb commented 2 years ago

reduced to 4 commits

rrthomas commented 2 years ago

I think it's better to have multiple commits as there are various unrelated fixes in this PR.

-- https://rrt.sc3d.org

On Thu, 9 Jun 2022, 17:07 Torben, @.***> wrote:

Alternatively you could select the squash option on the merge button. If you prefer multiple commits I can do the squashing.

— Reply to this email directly, view it on GitHub https://github.com/rrthomas/hpmor/pull/83#issuecomment-1151328629, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAEHZX2HJWGAC2AQUO36J3VOIJD3ANCNFSM5X7ZDK7A . You are receiving this because you commented.Message ID: @.***>