search

rrthomas / libpaper

Library and command-line tools for configuring and getting information on paper sizes
GNU Lesser General Public License v2.1
9 stars 11 forks source link

libpaper-2.0.10 breaks texlive 2023's psutils 'psresize' test. #43

Closed zarniwhoop73 closed 1 year ago

zarniwhoop73 commented 1 year ago

=============================================== psutils (TeX Live) 1.23: ./test-suite.log

TOTAL: 1

PASS: 0

SKIP: 0

XFAIL: 0

FAIL: 1

XPASS: 0

ERROR: 0

.. contents:: :depth: 2

FAIL: psutils

! /bin/sh -vx

$Id: psutils.test 48633 2018-09-09 17:56:55Z karl $

Copyright 2017-2018 Karl Berry tex-live@tug.org

Copyright 2011-2014 Peter Breitenlohner tex-live@tug.org

You may freely use, modify and/or distribute this file.

LC_ALL=C; export LC_ALL; LANGUAGE=C; export LANGUAGE

TEXMFCNF=$srcdir/../kpathsea; export TEXMFCNF

failed=

rm -rf play*

./psbook -s4 playsel.ps playbook.ps \ 2>playbook.2 \ && diff playbook.2 $srcdir/tests/playbook.2 \ && echo "psbook tests OK" \ || failed="$failed psbook"

./psresize -Pa4 -pa5 playsel.ps \ | sed -e 's/-0.000000 /0.000000 /' >playres.ps \ && diff playres.ps $srcdir/tests/playres.ps \ && echo "psresize tests OK" \ || failed="$failed psresize"

./psnup -pa4 -2 playsel.ps playnup.ps \ 2>playnup.2 \ && diff playnup.2 $srcdir/tests/playnup.2 \ && echo "psnup tests OK" \ || failed="$failed psnup"

./psselect 1:18 $srcdir/tests/play.ps 2>playsel1.2 \ | ./psnup -pa4 -18 >playnup1.ps 2>playnup1.2 \ && diff playsel1.2 $srcdir/tests/playsel1.2 \ && diff playnup1.2 $srcdir/tests/playnup1.2 \ && echo "psnup1 tests OK" \ || failed="$failed psnup1"

./pstops -pa4 '2:0L@.7(21cm,0)+1L@.7(21cm,14.85cm)' playsel.ps playps.ps \ 2>playps.2 \ && diff playps.2 $srcdir/tests/playps.2 \ && echo "pstops tests OK" \ || failed="$failed pstops"

rm -rf plot*

test -z "$failed" && exit 0

zarniwhoop73 commented 1 year ago

Sorry, I don't have any file managers, pasting plain text has been partially interpreted as markdown.

rrthomas commented 1 year ago

It looks as though the differences are well down in the final decimal digits. I'm not sure why this is happening, but I don't think it's significant. (I found some differences in the PSUtils test suite in PSUtils 2.x, but that's a different matter; in libpaper the only difference I can think of is that I fixed some paper sizes that were slightly inaccurate, but the differences were larger than the differences here!) libpaper 2 is now stable, so it should be possible to update the expected test outputs for that.

I'm also the maintainer of psutils, and it looks like you're using a rather out of date version (1.x, not 2.x). PSUtils 2 has its own test suite, and of course I test it against the latest version of libpaper. I will have a look at the TeXLive tests to see whether there are extra cases I could usefully add to the PSUtils test suite.

zarniwhoop73 commented 1 year ago

On Sun, Mar 26, 2023 at 02:13:35PM +0000, Reuben Thomas wrote:

It looks as though the differences are well down in the final decimal digits. I'm not sure why this is happening, but I don't think it's significant. libpaper 2 is now stable, so it should be possible to update the expected test outputs for that.

I'm also the maintainer of psutils, and it looks like you're using a rather out of date version (1.x, not 2.x). PSUtils 2 has its own test suite, and of course I test it against the latest version of libpaper. I will have a look at the TeXLive tests to see whether there are extra cases I could usefully add to the PSUtils test suite.

Thanks for the reply, unless I'm mistaken, my only psutils is what is shipped in texlive-20230313-source ?

-- Often there is no more than a little plaque to reveal that, against all gynaecological probability, someone very famous was born halfway up a wall. -- Equal Rites

rrthomas commented 1 year ago

Thanks for the reply, unless I'm mistaken, my only psutils is what is shipped in texlive-20230313-source ?

Sorry, I think I must have misunderstood what you're doing; I thought from the report that you must be a TeXLive maintainer, and so I was suggesting that TeXLive should update the version of psutils that it uses.

zarniwhoop73 commented 1 year ago

On Sun, Mar 26, 2023 at 08:38:01PM +0000, Reuben Thomas wrote:

Thanks for the reply, unless I'm mistaken, my only psutils is what is shipped in texlive-20230313-source ?

Sorry, I think I must have misunderstood what you're doing; I thought from the report that you must be a TeXLive maintainer, and so I was suggesting that TeXLive should update the version of psutils that it uses.

I've just found that fedora are patching texlive source for this, https://src.fedoraproject.org/rpms/texlive-base/raw/rawhide/f/texlive-base-libpaperv2.patch So for me that should solve the problem.

Thanks for your time, feel free to close this. -- Often there is no more than a little plaque to reveal that, against all gynaecological probability, someone very famous was born halfway up a wall. -- Equal Rites

rrthomas commented 1 year ago

By the way, I have added some of TeXLive's tests to PSUtils (on the python branch), and I did not have to patch the results for this issue, despite using libpaper 2.0.10. (The output of modern PSUtils does differ in a couple of other trivial ways.)