search

rrthomas / libpaper

Library and command-line tools for configuring and getting information on paper sizes
GNU Lesser General Public License v2.1
9 stars 11 forks source link

paperconf: Fix parameter -N #47

Closed zdohnal closed 1 year ago

zdohnal commented 1 year ago

Hi,

once paperconf was put back into libpaper, parameter -N is broken, because the first letter is always changed into lower case.

rrthomas commented 1 year ago

Thanks for the bug report!

I think your fix is not quite right, because if the first character of the paper name is uppercase, nothing will be printed. I think the correct fix is to change the call of printf_downcase in the else clause to just printf. I have committed such a fix; do feel free to comment!

zdohnal commented 1 year ago

Thanks, you're right, I've missed that test case. LGTM!

rrthomas commented 1 year ago

(I also released 2.1.1 with the fix.)