search

rrthomas / mmv

Other
50 stars 7 forks source link

Use of gc #9

Closed leahneukirchen closed 1 year ago

leahneukirchen commented 2 years ago

Is it really reasonable to use Boehm GC for a tool like this? It runs as one-shot only, so you could just leak the memory instead.

rrthomas commented 2 years ago

A little history (in case you don't know it): mmv used to have a simple custom allocator. I removed it, and couldn't work out the object lifetimes, so decided to use libgc (a technique I've used in the past). You're probably right about the one-shotness (the thought had occurred to me), but using libgc is more fun, I don't have to care whether leaking would be a problem or not, and ASAN doesn't complain.

I am not aware of the use of libgc causing any problems…?

leahneukirchen commented 2 years ago

It's just a library many systems don't necessarily have installed (here it's used only by inkscape, guile, w3m, zile...).

rrthomas commented 2 years ago

That's true, but it doesn't sound serious. (I'm responsible for Zile needing it; recent releases of Zile are written in Vala and don't need it.)

rrthomas commented 1 year ago

Closing, since this doesn't seem to be a problem.